Re: [PATCH] Keys: Add possessor permissions to keys

Trond Myklebust
2005-09-21T17:47:53Z

on den 21.09.2005 Klokka 10:15 (-0700) skreiv Andrew Morton:

> > + if (PTR_ERR(key_ref) != -EAGAIN) {
> > + if (IS_ERR(key_ref))
> > + key = key_deref(key_ref);
> > + else
> > + key = ERR_PTR(PTR_ERR(key_ref));
> > + break;
> > + }
> > + }
>
> That's getting a bit intimate with how IS_ERR and PTR_ERR are implemented
> but I guess we're unlikely to change that.

Shouldn't that test for IS_ERR(key_ref) be inverted?

Cheers,
Trond