From: Keith Owens <kaos@ocs.com.au>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: linux-kernel@vger.kernel.org, Russell King <rmk@arm.linux.org.uk>
Subject: Re: 2.6.3-rc3 serial console woes
Date: Tue, 17 Feb 2004 10:25:10 +1100 [thread overview]
Message-ID: <2719.1076973910@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Tue, 17 Feb 2004 08:05:54 +1100." <8778.1076965554@ocs3.ocs.com.au>
On Tue, 17 Feb 2004 08:05:54 +1100,
Keith Owens <kaos@sgi.com> wrote:
>On Mon, 16 Feb 2004 12:07:56 -0700,
>Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
>>Hmm.... I suspect the problem is that serial8250_isa_init_ports()
>>doesn't initialize port->type for the ports in SERIAL_PORT_DFNS,
>>so we fail the console setup.
>>===== drivers/serial/8250.c 1.44 vs edited =====
>>--- 1.44/drivers/serial/8250.c Fri Feb 13 08:19:33 2004
>>+++ edited/drivers/serial/8250.c Mon Feb 16 12:03:06 2004
>>@@ -1976,7 +1976,7 @@
>> if (co->index >= UART_NR)
>> co->index = 0;
>> port = &serial8250_ports[co->index].port;
>>- if (port->type == PORT_UNKNOWN)
>>+ if (!port->ops)
>> return -ENODEV;
>>
>> /*
>
>Works for me on i386.
Spoke too soon. That one line patch makes the serial console available
early in boot. But as soon as /sbin/init runs, the console is
gibberish due to a speed mismatch. Completely reverting
http://linux.bkbits.net:8080/linux-2.5/cset@1.1653?nav=index.html|ChangeSet@-7d
works fine. Since this is a -rc kernel, can we revert the cset until
it is fixed?
next prev parent reply other threads:[~2004-02-16 23:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-16 13:14 2.6.3-rc3 serial console woes Keith Owens
2004-02-16 19:07 ` Bjorn Helgaas
2004-02-16 21:05 ` Keith Owens
2004-02-16 23:25 ` Keith Owens [this message]
2004-02-16 23:45 ` Bjorn Helgaas
2004-02-17 1:53 ` Keith Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2719.1076973910@kao2.melbourne.sgi.com \
--to=kaos@ocs.com.au \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox