From: Mete Durlu <meted@linux.ibm.com>
To: Heiko Carstens <hca@linux.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Petr Mladek <pmladek@suse.com>, Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
Andreas Larsson <andreas@gaisler.com>,
Bradley Morgan <include@grrlz.net>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
sparclinux@vger.kernel.org
Subject: Re: [PATCH v4 2/3] s390: Implement arch_do_panic()
Date: Wed, 5 Aug 2026 12:11:38 +0200 [thread overview]
Message-ID: <271a228d-5ce3-49e4-8ea6-a39edccf1e46@linux.ibm.com> (raw)
In-Reply-To: <20260805100642.76476B64-hca@linux.ibm.com>
On 05/08/2026 12:06, Heiko Carstens wrote:
> On Wed, Aug 05, 2026 at 11:48:37AM +0200, Mete Durlu wrote:
>> Implement s390 specific arch_do_panic() instead of using s390 specific
>> ifdef sections in vpanic() code.
>> No functional changes.
>>
>> Signed-off-by: Mete Durlu <meted@linux.ibm.com>
>> ---
>> arch/s390/kernel/ipl.c | 6 ++++++
>> kernel/panic.c | 3 ---
>> 2 files changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/s390/kernel/ipl.c b/arch/s390/kernel/ipl.c
>> index 3c346b02ceb9..31ff7c12c354 100644
>> --- a/arch/s390/kernel/ipl.c
>> +++ b/arch/s390/kernel/ipl.c
>> @@ -13,6 +13,7 @@
>> #include <linux/device.h>
>> #include <linux/delay.h>
>> #include <linux/kstrtox.h>
>> +#include <linux/panic.h>
>> #include <linux/panic_notifier.h>
>> #include <linux/reboot.h>
>> #include <linux/ctype.h>
>> @@ -2343,6 +2344,11 @@ static struct notifier_block on_panic_nb = {
>> .priority = INT_MIN,
>> };
>>
>> +void arch_do_panic(void)
>> +{
>> + disabled_wait();
>> +}
>> +
>
> Please move this to arch/s390/kernel/traps.c somewhere near
> kernel_stack_invalid() and monitor_event_exception().
Alright, will do in the next version.
Thank you for having a look!
next prev parent reply other threads:[~2026-08-05 10:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 9:48 [PATCH v4 0/3] Introduce arch_do_panic Mete Durlu
2026-08-05 9:48 ` [PATCH v4 1/3] panic: " Mete Durlu
2026-08-05 9:48 ` [PATCH v4 2/3] s390: Implement arch_do_panic() Mete Durlu
2026-08-05 10:06 ` Heiko Carstens
2026-08-05 10:11 ` Mete Durlu [this message]
2026-08-05 9:48 ` [PATCH v4 3/3] sparc: Implement arch_do_panic Mete Durlu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=271a228d-5ce3-49e4-8ea6-a39edccf1e46@linux.ibm.com \
--to=meted@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andreas@gaisler.com \
--cc=borntraeger@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=include@grrlz.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=sparclinux@vger.kernel.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox