* [PATCH 0/2] Add Samsung Galaxy Note 3 support
@ 2024-03-10 14:13 Luca Weiss
2024-03-10 14:13 ` [PATCH 1/2] dt-bindings: arm: qcom: Add Samsung Galaxy Note 3 Luca Weiss
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Luca Weiss @ 2024-03-10 14:13 UTC (permalink / raw)
To: ~postmarketos/upstreaming, phone-devel, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Adam Honse
Cc: linux-arm-msm, devicetree, linux-kernel, Luca Weiss
Add the dts for "hlte" which is a phablet from 2013.
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
Adam Honse (1):
ARM: dts: qcom: msm8974: Add Samsung Galaxy Note 3
Luca Weiss (1):
dt-bindings: arm: qcom: Add Samsung Galaxy Note 3
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
arch/arm/boot/dts/qcom/Makefile | 1 +
.../boot/dts/qcom/qcom-msm8974-samsung-hlte.dts | 403 +++++++++++++++++++++
3 files changed, 405 insertions(+)
---
base-commit: 90d35da658da8cff0d4ecbb5113f5fac9d00eb72
change-id: 20240310-samsung-hlte-78d1a287b0a8
Best regards,
--
Luca Weiss <luca@z3ntu.xyz>
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 1/2] dt-bindings: arm: qcom: Add Samsung Galaxy Note 3 2024-03-10 14:13 [PATCH 0/2] Add Samsung Galaxy Note 3 support Luca Weiss @ 2024-03-10 14:13 ` Luca Weiss 2024-03-10 17:30 ` Krzysztof Kozlowski 2024-03-10 14:13 ` [PATCH 2/2] ARM: dts: qcom: msm8974: " Luca Weiss 2024-03-11 14:23 ` [PATCH 0/2] Add Samsung Galaxy Note 3 support Rob Herring 2 siblings, 1 reply; 7+ messages in thread From: Luca Weiss @ 2024-03-10 14:13 UTC (permalink / raw) To: ~postmarketos/upstreaming, phone-devel, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Adam Honse Cc: linux-arm-msm, devicetree, linux-kernel, Luca Weiss Add the compatible for this Samsung smartphone ("phablet" as it was named in that era). Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 1a5fb889a444..57182bfa27ee 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -214,6 +214,7 @@ properties: - items: - enum: - lge,hammerhead + - samsung,hlte - sony,xperia-amami - sony,xperia-honami - const: qcom,msm8974 -- 2.44.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: qcom: Add Samsung Galaxy Note 3 2024-03-10 14:13 ` [PATCH 1/2] dt-bindings: arm: qcom: Add Samsung Galaxy Note 3 Luca Weiss @ 2024-03-10 17:30 ` Krzysztof Kozlowski 0 siblings, 0 replies; 7+ messages in thread From: Krzysztof Kozlowski @ 2024-03-10 17:30 UTC (permalink / raw) To: Luca Weiss, ~postmarketos/upstreaming, phone-devel, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Adam Honse Cc: linux-arm-msm, devicetree, linux-kernel On 10/03/2024 15:13, Luca Weiss wrote: > Add the compatible for this Samsung smartphone ("phablet" as it was > named in that era). > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] ARM: dts: qcom: msm8974: Add Samsung Galaxy Note 3 2024-03-10 14:13 [PATCH 0/2] Add Samsung Galaxy Note 3 support Luca Weiss 2024-03-10 14:13 ` [PATCH 1/2] dt-bindings: arm: qcom: Add Samsung Galaxy Note 3 Luca Weiss @ 2024-03-10 14:13 ` Luca Weiss 2024-03-14 10:02 ` Konrad Dybcio 2024-03-11 14:23 ` [PATCH 0/2] Add Samsung Galaxy Note 3 support Rob Herring 2 siblings, 1 reply; 7+ messages in thread From: Luca Weiss @ 2024-03-10 14:13 UTC (permalink / raw) To: ~postmarketos/upstreaming, phone-devel, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Adam Honse Cc: linux-arm-msm, devicetree, linux-kernel, Luca Weiss From: Adam Honse <calcprogrammer1@gmail.com> Add the devicetree for this "phablet" using the Snapdragon 800 SoC. Signed-off-by: Adam Honse <calcprogrammer1@gmail.com> [luca@z3ntu.xyz: clean up, prepare for upstream] Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- arch/arm/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/qcom-msm8974-samsung-hlte.dts | 403 +++++++++++++++++++++ 2 files changed, 404 insertions(+) diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile index 9cc1e14e6cd0..845af12d15a2 100644 --- a/arch/arm/boot/dts/qcom/Makefile +++ b/arch/arm/boot/dts/qcom/Makefile @@ -39,6 +39,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \ qcom-msm8960-cdp.dtb \ qcom-msm8960-samsung-expressatt.dtb \ qcom-msm8974-lge-nexus5-hammerhead.dtb \ + qcom-msm8974-samsung-hlte.dtb \ qcom-msm8974-sony-xperia-rhine-amami.dtb \ qcom-msm8974-sony-xperia-rhine-honami.dtb \ qcom-msm8974pro-fairphone-fp2.dtb \ diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dts b/arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dts new file mode 100644 index 000000000000..e03227a49b67 --- /dev/null +++ b/arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dts @@ -0,0 +1,403 @@ +// SPDX-License-Identifier: GPL-2.0 +#include "qcom-msm8974.dtsi" +#include "pm8841.dtsi" +#include "pm8941.dtsi" +#include <dt-bindings/input/input.h> +#include <dt-bindings/leds/common.h> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h> + +/ { + model = "Samsung Galaxy Note 3"; + compatible = "samsung,hlte", "qcom,msm8974"; + chassis-type = "handset"; + + aliases { + mmc0 = &sdhc_1; /* SDC1 eMMC slot */ + mmc1 = &sdhc_3; /* SDC3 SD card slot */ + serial0 = &blsp1_uart1; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; + + gpio-keys { + compatible = "gpio-keys"; + + pinctrl-names = "default"; + pinctrl-0 = <&gpio_keys_pin_a>; + + key-home { + label = "home_key"; + gpios = <&pm8941_gpios 3 GPIO_ACTIVE_LOW>; + linux,code = <KEY_HOMEPAGE>; + wakeup-source; + debounce-interval = <15>; + }; + + key-volume-down { + label = "volume_down"; + gpios = <&pm8941_gpios 2 GPIO_ACTIVE_LOW>; + linux,code = <KEY_VOLUMEDOWN>; + debounce-interval = <15>; + }; + + key-volume-up { + label = "volume_up"; + gpios = <&pm8941_gpios 5 GPIO_ACTIVE_LOW>; + linux,code = <KEY_VOLUMEUP>; + debounce-interval = <15>; + }; + }; + + touch_ldo: regulator-touch { + compatible = "regulator-fixed"; + regulator-name = "touch-ldo"; + + gpio = <&pm8941_gpios 9 GPIO_ACTIVE_HIGH>; + enable-active-high; + regulator-boot-on; + + pinctrl-names = "default"; + pinctrl-0 = <&touch_ldo_pin>; + }; +}; + +&blsp1_i2c2 { + status = "okay"; + + touchscreen@20 { + compatible = "syna,rmi4-i2c"; + reg = <0x20>; + + interrupt-parent = <&pm8941_gpios>; + interrupts = <30 IRQ_TYPE_EDGE_FALLING>; + + vdd-supply = <&pm8941_l10>; + vio-supply = <&touch_ldo>; + + pinctrl-names = "default"; + pinctrl-0 = <&touch_pin>; + + syna,startup-delay-ms = <100>; + + #address-cells = <1>; + #size-cells = <0>; + + rmi4-f01@1 { + reg = <0x1>; + syna,nosleep-mode = <1>; + }; + + rmi4-f12@12 { + reg = <0x12>; + syna,sensor-type = <1>; + }; + }; +}; + +&blsp2_i2c6 { + status = "okay"; + + fuelgauge@36 { + compatible = "maxim,max17048"; + reg = <0x36>; + + maxim,double-soc; + maxim,rcomp = /bits/ 8 <0x56>; + + interrupt-parent = <&pm8941_gpios>; + interrupts = <26 IRQ_TYPE_EDGE_FALLING>; + + pinctrl-names = "default"; + pinctrl-0 = <&fuelgauge_pin>; + }; +}; + +&blsp1_uart2 { + status = "okay"; +}; + +&pm8941_gpios { + gpio_keys_pin_a: gpio-keys-active-state { + pins = "gpio2", "gpio3", "gpio5"; + function = "normal"; + bias-pull-up; + power-source = <PM8941_GPIO_S3>; + }; + + fuelgauge_pin: fuelgauge-int-state { + pins = "gpio26"; + function = "normal"; + bias-disable; + input-enable; + power-source = <PM8941_GPIO_S3>; + }; + + touch_pin: touchscreen-int-state { + pins = "gpio30"; + function = "normal"; + bias-disable; + input-enable; + power-source = <PM8941_GPIO_S3>; + }; + + touch_ldo_pin: touchscreen-ldo-state { + pins = "gpio9"; + function = "normal"; + output-high; + power-source = <PM8941_GPIO_S3>; + qcom,drive-strength = <PMIC_GPIO_STRENGTH_HIGH>; + }; +}; + +&remoteproc_adsp { + cx-supply = <&pm8841_s2>; + status = "okay"; +}; + +&remoteproc_mss { + cx-supply = <&pm8841_s2>; + mss-supply = <&pm8841_s3>; + mx-supply = <&pm8841_s1>; + pll-supply = <&pm8941_l12>; + status = "okay"; +}; + +&rpm_requests { + regulators-0 { + compatible = "qcom,rpm-pm8841-regulators"; + + pm8841_s1: s1 { + regulator-min-microvolt = <675000>; + regulator-max-microvolt = <1050000>; + }; + + pm8841_s2: s2 { + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <1050000>; + }; + + pm8841_s3: s3 { + regulator-min-microvolt = <1050000>; + regulator-max-microvolt = <1050000>; + }; + + pm8841_s4: s4 { + regulator-min-microvolt = <815000>; + regulator-max-microvolt = <900000>; + }; + }; + + regulators-1 { + compatible = "qcom,rpm-pm8941-regulators"; + + pm8941_s1: s1 { + regulator-min-microvolt = <1300000>; + regulator-max-microvolt = <1300000>; + regulator-always-on; + }; + + pm8941_s2: s2 { + regulator-min-microvolt = <2150000>; + regulator-max-microvolt = <2150000>; + }; + + pm8941_s3: s3 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + pm8941_l1: l1 { + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + }; + + pm8941_l2: l2 { + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + }; + + pm8941_l3: l3 { + regulator-min-microvolt = <1050000>; + regulator-max-microvolt = <1225000>; + }; + + pm8941_l4: l4 { + regulator-min-microvolt = <1225000>; + regulator-max-microvolt = <1225000>; + }; + + pm8941_l5: l5 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + pm8941_l6: l6 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + pm8941_l7: l7 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + pm8941_l8: l8 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + pm8941_l9: l9 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <2950000>; + }; + + pm8941_l10: l10 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + pm8941_l11: l11 { + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1350000>; + }; + + pm8941_l12: l12 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + }; + + pm8941_l13: l13 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + }; + + pm8941_l14: l14 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + pm8941_l15: l15 { + regulator-min-microvolt = <2050000>; + regulator-max-microvolt = <2050000>; + }; + + pm8941_l16: l16 { + regulator-min-microvolt = <2700000>; + regulator-max-microvolt = <2700000>; + }; + + pm8941_l17: l17 { + regulator-min-microvolt = <2850000>; + regulator-max-microvolt = <3000000>; + }; + + pm8941_l18: l18 { + regulator-min-microvolt = <2850000>; + regulator-max-microvolt = <2850000>; + }; + + pm8941_l19: l19 { + regulator-min-microvolt = <2900000>; + regulator-max-microvolt = <3350000>; + }; + + pm8941_l20: l20 { + regulator-min-microvolt = <2950000>; + regulator-max-microvolt = <2950000>; + + regulator-allow-set-load; + regulator-system-load = <200000>; + }; + + pm8941_l21: l21 { + regulator-min-microvolt = <2950000>; + regulator-max-microvolt = <2950000>; + + regulator-allow-set-load; + regulator-system-load = <200000>; + }; + + pm8941_l22: l22 { + regulator-min-microvolt = <2500000>; + regulator-max-microvolt = <3000000>; + }; + + pm8941_l23: l23 { + regulator-min-microvolt = <2400000>; + regulator-max-microvolt = <3300000>; + }; + + pm8941_l24: l24 { + regulator-min-microvolt = <3075000>; + regulator-max-microvolt = <3075000>; + }; + }; +}; + +&sdhc_1 { + vmmc-supply = <&pm8941_l20>; + vqmmc-supply = <&pm8941_s3>; + + pinctrl-names = "default"; + pinctrl-0 = <&sdhc1_pin_a>; + + status = "okay"; +}; + +&sdhc_3 { + max-frequency = <100000000>; + + vmmc-supply = <&pm8941_l21>; + vqmmc-supply = <&pm8941_l21>; + + pinctrl-names = "default"; + pinctrl-0 = <&sdhc3_pin_a>; + + status = "okay"; +}; + +&tlmm { + sdhc1_pin_a: sdhc1-pin-active-state { + clk-pins { + pins = "sdc1_clk"; + drive-strength = <4>; + bias-disable; + }; + + cmd-data-pins { + pins = "sdc1_cmd", "sdc1_data"; + drive-strength = <4>; + bias-pull-up; + }; + }; + + sdhc3_pin_a: sdhc3-pin-active-state { + pins = "gpio35", "gpio36", "gpio37", "gpio38", "gpio39", "gpio40"; + function = "sdc3"; + drive-strength = <8>; + bias-disable; + }; +}; + +&usb { + phys = <&usb_hs1_phy>; + phy-select = <&tcsr 0xb000 0>; + + hnp-disable; + srp-disable; + adp-disable; + + status = "okay"; +}; + +&usb_hs1_phy { + v1p8-supply = <&pm8941_l6>; + v3p3-supply = <&pm8941_l24>; + + qcom,init-seq = /bits/ 8 <0x1 0x64>; + + status = "okay"; +}; -- 2.44.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] ARM: dts: qcom: msm8974: Add Samsung Galaxy Note 3 2024-03-10 14:13 ` [PATCH 2/2] ARM: dts: qcom: msm8974: " Luca Weiss @ 2024-03-14 10:02 ` Konrad Dybcio 0 siblings, 0 replies; 7+ messages in thread From: Konrad Dybcio @ 2024-03-14 10:02 UTC (permalink / raw) To: Luca Weiss, ~postmarketos/upstreaming, phone-devel, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Adam Honse Cc: linux-arm-msm, devicetree, linux-kernel On 3/10/24 15:13, Luca Weiss wrote: > From: Adam Honse <calcprogrammer1@gmail.com> > > Add the devicetree for this "phablet" using the Snapdragon 800 SoC. > > Signed-off-by: Adam Honse <calcprogrammer1@gmail.com> > [luca@z3ntu.xyz: clean up, prepare for upstream] > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- > arch/arm/boot/dts/qcom/Makefile | 1 + > .../boot/dts/qcom/qcom-msm8974-samsung-hlte.dts | 403 +++++++++++++++++++++ > 2 files changed, 404 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile > index 9cc1e14e6cd0..845af12d15a2 100644 > --- a/arch/arm/boot/dts/qcom/Makefile > +++ b/arch/arm/boot/dts/qcom/Makefile > @@ -39,6 +39,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \ > qcom-msm8960-cdp.dtb \ > qcom-msm8960-samsung-expressatt.dtb \ > qcom-msm8974-lge-nexus5-hammerhead.dtb \ > + qcom-msm8974-samsung-hlte.dtb \ > qcom-msm8974-sony-xperia-rhine-amami.dtb \ > qcom-msm8974-sony-xperia-rhine-honami.dtb \ > qcom-msm8974pro-fairphone-fp2.dtb \ > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dts b/arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dts > new file mode 100644 > index 000000000000..e03227a49b67 > --- /dev/null > +++ b/arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dts > @@ -0,0 +1,403 @@ > +// SPDX-License-Identifier: GPL-2.0 > +#include "qcom-msm8974.dtsi" > +#include "pm8841.dtsi" > +#include "pm8941.dtsi" > +#include <dt-bindings/input/input.h> > +#include <dt-bindings/leds/common.h> > +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h> > + > +/ { > + model = "Samsung Galaxy Note 3"; > + compatible = "samsung,hlte", "qcom,msm8974"; > + chassis-type = "handset"; > + > + aliases { > + mmc0 = &sdhc_1; /* SDC1 eMMC slot */ > + mmc1 = &sdhc_3; /* SDC3 SD card slot */ > + serial0 = &blsp1_uart1; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&gpio_keys_pin_a>; property-n property-names > + > + key-home { > + label = "home_key"; "Home Key" etc. > + > + pm8941_l20: l20 { > + regulator-min-microvolt = <2950000>; > + regulator-max-microvolt = <2950000>; > + > + regulator-allow-set-load; > + regulator-system-load = <200000>; regulator-min-microvolt = <2950000>; regulator-max-microvolt = <2950000>; regulator-system-load = <200000>; regulator-allow-set-load; [...] Konrad ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] Add Samsung Galaxy Note 3 support 2024-03-10 14:13 [PATCH 0/2] Add Samsung Galaxy Note 3 support Luca Weiss 2024-03-10 14:13 ` [PATCH 1/2] dt-bindings: arm: qcom: Add Samsung Galaxy Note 3 Luca Weiss 2024-03-10 14:13 ` [PATCH 2/2] ARM: dts: qcom: msm8974: " Luca Weiss @ 2024-03-11 14:23 ` Rob Herring 2024-03-11 16:53 ` Luca Weiss 2 siblings, 1 reply; 7+ messages in thread From: Rob Herring @ 2024-03-11 14:23 UTC (permalink / raw) To: Luca Weiss Cc: linux-arm-msm, Bjorn Andersson, Krzysztof Kozlowski, Conor Dooley, Rob Herring, ~postmarketos/upstreaming, devicetree, linux-kernel, Konrad Dybcio, phone-devel, Adam Honse On Sun, 10 Mar 2024 15:13:35 +0100, Luca Weiss wrote: > Add the dts for "hlte" which is a phablet from 2013. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- > Adam Honse (1): > ARM: dts: qcom: msm8974: Add Samsung Galaxy Note 3 > > Luca Weiss (1): > dt-bindings: arm: qcom: Add Samsung Galaxy Note 3 > > Documentation/devicetree/bindings/arm/qcom.yaml | 1 + > arch/arm/boot/dts/qcom/Makefile | 1 + > .../boot/dts/qcom/qcom-msm8974-samsung-hlte.dts | 403 +++++++++++++++++++++ > 3 files changed, 405 insertions(+) > --- > base-commit: 90d35da658da8cff0d4ecbb5113f5fac9d00eb72 > change-id: 20240310-samsung-hlte-78d1a287b0a8 > > Best regards, > -- > Luca Weiss <luca@z3ntu.xyz> > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y qcom/qcom-msm8974-samsung-hlte.dtb' for 20240310-samsung-hlte-v1-0-e9b55bf98a48@z3ntu.xyz: arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dtb: /: memory: False schema does not allow {'device_type': ['memory'], 'reg': [[0, 0]]} from schema $id: http://devicetree.org/schemas/root-node.yaml# arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dtb: l2-cache: Unevaluated properties are not allowed ('qcom,saw' was unexpected) from schema $id: http://devicetree.org/schemas/cache.yaml# arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dtb: idle-states: 'spc' does not match any of the regexes: '^(cpu|cluster)-', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/cpu/idle-states.yaml# arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dtb: syscon@f9011000: compatible: 'anyOf' conditional failed, one must be fixed: ['syscon'] is too short 'syscon' is not one of ['allwinner,sun8i-a83t-system-controller', 'allwinner,sun8i-h3-system-controller', 'allwinner,sun8i-v3s-system-controller', 'allwinner,sun50i-a64-system-controller', 'amd,pensando-elba-syscon', 'brcm,cru-clkset', 'freecom,fsg-cs2-system-controller', 'fsl,imx93-aonmix-ns-syscfg', 'fsl,imx93-wakeupmix-syscfg', 'hisilicon,dsa-subctrl', 'hisilicon,hi6220-sramctrl', 'hisilicon,pcie-sas-subctrl', 'hisilicon,peri-subctrl', 'hpe,gxp-sysreg', 'intel,lgm-syscon', 'loongson,ls1b-syscon', 'loongson,ls1c-syscon', 'marvell,armada-3700-usb2-host-misc', 'mediatek,mt8135-pctl-a-syscfg', 'mediatek,mt8135-pctl-b-syscfg', 'mediatek,mt8365-syscfg', 'microchip,lan966x-cpu-syscon', 'microchip,sparx5-cpu-syscon', 'mstar,msc313-pmsleep', 'nuvoton,ma35d1-sys', 'nuvoton,wpcm450-shm', 'rockchip,px30-qos', 'rockchip,rk3036-qos', 'rockchip,rk3066-qos', 'rockchip,rk3128-qos', 'rockchip,rk3228-qos', 'rockchip,rk3288-qos', 'rockchip,rk3368-qos', 'rockchip,rk3399-qos', 'rockchip,rk3568-qos', 'rockchip,rk3588-qos', 'rockchip,rv1126-qos', 'starfive,jh7100-sysmain', 'ti,am62-usb-phy-ctrl', 'ti,am654-dss-oldi-io-ctrl', 'ti,am654-serdes-ctrl', 'ti,j784s4-pcie-ctrl'] from schema $id: http://devicetree.org/schemas/mfd/syscon.yaml# ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] Add Samsung Galaxy Note 3 support 2024-03-11 14:23 ` [PATCH 0/2] Add Samsung Galaxy Note 3 support Rob Herring @ 2024-03-11 16:53 ` Luca Weiss 0 siblings, 0 replies; 7+ messages in thread From: Luca Weiss @ 2024-03-11 16:53 UTC (permalink / raw) To: Rob Herring Cc: linux-arm-msm, Bjorn Andersson, Krzysztof Kozlowski, Conor Dooley, Rob Herring, ~postmarketos/upstreaming, devicetree, linux-kernel, Konrad Dybcio, phone-devel, Adam Honse On Montag, 11. März 2024 15:23:30 CET Rob Herring wrote: > > On Sun, 10 Mar 2024 15:13:35 +0100, Luca Weiss wrote: > > Add the dts for "hlte" which is a phablet from 2013. > > > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > > --- > > Adam Honse (1): > > ARM: dts: qcom: msm8974: Add Samsung Galaxy Note 3 > > > > Luca Weiss (1): > > dt-bindings: arm: qcom: Add Samsung Galaxy Note 3 > > > > Documentation/devicetree/bindings/arm/qcom.yaml | 1 + > > arch/arm/boot/dts/qcom/Makefile | 1 + > > .../boot/dts/qcom/qcom-msm8974-samsung-hlte.dts | 403 +++++++++++++++++++++ > > 3 files changed, 405 insertions(+) > > --- > > base-commit: 90d35da658da8cff0d4ecbb5113f5fac9d00eb72 > > change-id: 20240310-samsung-hlte-78d1a287b0a8 > > > > Best regards, > > -- > > Luca Weiss <luca@z3ntu.xyz> > > > > > > > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y qcom/qcom-msm8974-samsung-hlte.dtb' for 20240310-samsung-hlte-v1-0-e9b55bf98a48@z3ntu.xyz: > > arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dtb: /: memory: False schema does not allow {'device_type': ['memory'], 'reg': [[0, 0]]} > from schema $id: http://devicetree.org/schemas/root-node.yaml# > arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dtb: l2-cache: Unevaluated properties are not allowed ('qcom,saw' was unexpected) > from schema $id: http://devicetree.org/schemas/cache.yaml# > arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dtb: idle-states: 'spc' does not match any of the regexes: '^(cpu|cluster)-', 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/cpu/idle-states.yaml# > arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dtb: syscon@f9011000: compatible: 'anyOf' conditional failed, one must be fixed: > ['syscon'] is too short > 'syscon' is not one of ['allwinner,sun8i-a83t-system-controller', 'allwinner,sun8i-h3-system-controller', 'allwinner,sun8i-v3s-system-controller', 'allwinner,sun50i-a64-system-controller', 'amd,pensando-elba-syscon', 'brcm,cru-clkset', 'freecom,fsg-cs2-system-controller', 'fsl,imx93-aonmix-ns-syscfg', 'fsl,imx93-wakeupmix-syscfg', 'hisilicon,dsa-subctrl', 'hisilicon,hi6220-sramctrl', 'hisilicon,pcie-sas-subctrl', 'hisilicon,peri-subctrl', 'hpe,gxp-sysreg', 'intel,lgm-syscon', 'loongson,ls1b-syscon', 'loongson,ls1c-syscon', 'marvell,armada-3700-usb2-host-misc', 'mediatek,mt8135-pctl-a-syscfg', 'mediatek,mt8135-pctl-b-syscfg', 'mediatek,mt8365-syscfg', 'microchip,lan966x-cpu-syscon', 'microchip,sparx5-cpu-syscon', 'mstar,msc313-pmsleep', 'nuvoton,ma35d1-sys', 'nuvoton,wpcm450-shm', 'rockchip,px30-qos', 'rockchip,rk3036-qos', 'rockchip,rk3066-qos', 'rockchip,rk3128-qos', 'rockchip,rk3228-qos', 'rockchip,rk3288-qos', 'rockchip,rk3368-qos', 'rockchip,rk3399-qos', 'rockchip,rk3568-qos', ' > rockchip,rk3588-qos', 'rockchip,rv1126-qos', 'starfive,jh7100-sysmain', 'ti,am62-usb-phy-ctrl', 'ti,am654-dss-oldi-io-ctrl', 'ti,am654-serdes-ctrl', 'ti,j784s4-pcie-ctrl'] > from schema $id: http://devicetree.org/schemas/mfd/syscon.yaml# Unfortunately all existing warnings from the .dtsi. Regards Luca ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-03-14 10:02 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-03-10 14:13 [PATCH 0/2] Add Samsung Galaxy Note 3 support Luca Weiss 2024-03-10 14:13 ` [PATCH 1/2] dt-bindings: arm: qcom: Add Samsung Galaxy Note 3 Luca Weiss 2024-03-10 17:30 ` Krzysztof Kozlowski 2024-03-10 14:13 ` [PATCH 2/2] ARM: dts: qcom: msm8974: " Luca Weiss 2024-03-14 10:02 ` Konrad Dybcio 2024-03-11 14:23 ` [PATCH 0/2] Add Samsung Galaxy Note 3 support Rob Herring 2024-03-11 16:53 ` Luca Weiss
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox