From: Ben Skeggs <bskeggs@redhat.com>
To: "Geyslan Gregório Bem" <geyslan@gmail.com>
Cc: Felipe Pena <felipensp@gmail.com>,
airlied@linux.ie, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
kernel-br <kernel-br@googlegroups.com>
Subject: Re: [PATCH] drm: nouveau: fix nvbe leakage
Date: Mon, 7 Oct 2013 21:34:20 -0400 (EDT) [thread overview]
Message-ID: <272096591.2542958.1381196060612.JavaMail.root@redhat.com> (raw)
In-Reply-To: <CAGG-pUQGKmCQ_N2z5puPZYufW31keP-7sRBJRN=VGCkjZ+US9Q@mail.gmail.com>
----- Original Message -----
> From: "Geyslan Gregório Bem" <geyslan@gmail.com>
> To: "Felipe Pena" <felipensp@gmail.com>
> Cc: "Ben Skeggs" <bskeggs@redhat.com>, airlied@linux.ie, dri-devel@lists.freedesktop.org,
> linux-kernel@vger.kernel.org, "kernel-br" <kernel-br@googlegroups.com>
> Sent: Tuesday, 8 October, 2013 9:39:02 AM
> Subject: Re: [PATCH] drm: nouveau: fix nvbe leakage
>
> Felipe, thank you too.
>
> I realized this after a code review.
>
> Ben, what do you think?
>
> Geyslan Gregório Bem
> hackingbits.com
>
>
> 2013/10/7 Felipe Pena <felipensp@gmail.com>:
> > Hi,
> >
> > On Mon, Oct 7, 2013 at 7:35 PM, Ben Skeggs <bskeggs@redhat.com> wrote:
> >> ----- Original Message -----
> >>> From: "Geyslan G. Bem" <geyslan@gmail.com>
> >>> To: airlied@linux.ie, bskeggs@redhat.com, dri-devel@lists.freedesktop.org
> >>> Cc: linux-kernel@vger.kernel.org, kernel-br@googlegroups.com, "Geyslan G.
> >>> Bem" <geyslan@gmail.com>
> >>> Sent: Tuesday, 8 October, 2013 8:14:26 AM
> >>> Subject: [PATCH] drm: nouveau: fix nvbe leakage
> >>>
> >>> Free memory allocated to nvbe when returning NULL.
> >>>
> >>> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
> >> NACK. ttm_dma_tt_init() calls the destructor if it fails, which frees the
> >> memory.
> >>
> >> Ben.
> >>
> >
> > But ttm_tt_destroy() just handles the ttm_tt part from nvbe, the nvbe
> > pointer itself is not being free'd.
Actually look at ttm_tt_destroy() and you'll see that right at the end it goes ttm->func->destroy(ttm), which is nouveau_sgdma_destroy().
Ben.
> >
> >>> ---
> >>> drivers/gpu/drm/nouveau/nouveau_sgdma.c | 3 +++
> >>> 1 file changed, 3 insertions(+)
> >>>
> >>> diff --git a/drivers/gpu/drm/nouveau/nouveau_sgdma.c
> >>> b/drivers/gpu/drm/nouveau/nouveau_sgdma.c
> >>> index 0843ebc..af8b66d 100644
> >>> --- a/drivers/gpu/drm/nouveau/nouveau_sgdma.c
> >>> +++ b/drivers/gpu/drm/nouveau/nouveau_sgdma.c
> >>> @@ -105,6 +105,9 @@ nouveau_sgdma_create_ttm(struct ttm_bo_device *bdev,
> >>> nvbe->ttm.ttm.func = &nv50_sgdma_backend;
> >>>
> >>> if (ttm_dma_tt_init(&nvbe->ttm, bdev, size, page_flags,
> >>> dummy_read_page))
> >>> + {
> >>> + kfree(nvbe);
> >>> return NULL;
> >>> + }
> >>> return &nvbe->ttm.ttm;
> >>> }
> >>> --
> >>> 1.8.4
> >>>
> >>>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> >> Please read the FAQ at http://www.tux.org/lkml/
> >
> >
> >
> > --
> > Regards,
> > Felipe Pena
>
next prev parent reply other threads:[~2013-10-08 1:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 22:14 [PATCH] drm: nouveau: fix nvbe leakage Geyslan G. Bem
2013-10-07 22:35 ` Ben Skeggs
2013-10-07 23:36 ` Felipe Pena
2013-10-07 23:39 ` Geyslan Gregório Bem
2013-10-08 1:34 ` Ben Skeggs [this message]
2013-10-08 9:15 ` Geyslan Gregório Bem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=272096591.2542958.1381196060612.JavaMail.root@redhat.com \
--to=bskeggs@redhat.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=felipensp@gmail.com \
--cc=geyslan@gmail.com \
--cc=kernel-br@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).