From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8136053372; Wed, 24 Apr 2024 16:33:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.198 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713976386; cv=none; b=YciiiTGC5VbH3DQACoiHGkqunTkyU/1ZRs1AIU0Sm9wtwMuX0ChulWm8eVMwd7QkE6Is1kzvB/L5la7VDUUcMGQwo0/9uXbeXTOrmdMsBc+DzLbqdL8u4x5ah1CFTtmQCA2wT8NWxTlvy+hFGz7F+jIJleTdaGVtx9mdg5jL6Fc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713976386; c=relaxed/simple; bh=z3eF70FQlQ72XvDhpe9rqk8ScoUbO1zXys/ZqDSFff8=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=EsJFQDEcLhk0fHrYPYoe9EZiu11tL3ubDWunuN5Qa6QFR1xiKcBtHySOjFoGkuJut66dO+8vITb5V1GVICyLDDkV8LBVck39x+gNMHctX5N2kRXPQywMHJ0ItymxUDczOO14h+SbClZ4jzogUPc6iDMNhNGJUpjykDx4lfdOJWQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=iMVDtcco; arc=none smtp.client-ip=217.70.183.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="iMVDtcco" Received: by mail.gandi.net (Postfix) with ESMTPSA id 21B53C000F; Wed, 24 Apr 2024 16:32:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1713976375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nVfX6CunHv0QJSiX7CwyfL7fs8TD4zil05zPYCaSh6k=; b=iMVDtccoEjyJoeXjQJLTyW/F8IkBaa/rp9MWSak72TbmK3OD5QfxAjn1in6WE98ZtBUyR5 3P30Xa4NYEDOJWfQc45QcD3YdXvSv1WDXSusY+dtDC2jdM6pibXjIRocRI5egVRjFP2OOy ee13xRwe4nIhFtLSEg+D4hnIG/x9FNg9Y/zCSi8RjeyuNd8Oq5T4u1mYLqcrrN3fg2y5tg Mt8UhDahzyzg/3U7hicTJd9RbTxtnMHLCFR+RR6ZXQS+6gwZsApMHLOAIPN2expFnKgqOX Zi3tqaEjw8QcWzUf0o8XEAtexPfEvmQSk/JdjNpfLv+x9+AZ58jWDqhqAICBGQ== Date: Wed, 24 Apr 2024 18:33:30 +0200 (CEST) From: Romain Gantois To: Serge Semin cc: Romain Gantois , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Russell King , =?ISO-8859-15?Q?Cl=E9ment_L=E9ger?= , Thomas Petazzoni , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, "Russell King (Oracle)" , Maxime Chevallier Subject: Re: [PATCH net-next v4 2/5] net: stmmac: introduce pcs_init/pcs_exit stmmac operations In-Reply-To: Message-ID: <27279f1a-e718-a8cf-ecfc-40f45bf6c500@bootlin.com> References: <20240424-rzn1-gmac1-v4-0-852a5f2ce0c0@bootlin.com> <20240424-rzn1-gmac1-v4-2-852a5f2ce0c0@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-GND-Sasl: romain.gantois@bootlin.com Hi Serge, On Wed, 24 Apr 2024, Serge Semin wrote: > Once again. There is a ready-to-use stmmac_xpcs_setup() method. Which > is currently intended for the XPCS setups. Let's collect all the > PCS-related stuff in a single place there. That will make code cleaner > and easier to read. This was discussed on v3: > > https://lore.kernel.org/netdev/42chuecdt7dpgm6fcrtt2crifvv5hflmtnmdrw5fvk3r7pwjgu@hlcv56dbeosf/ > > You agreed to do that, but just ignored in result. I'll repeat what I > said in v3: Yeah sorry I took a quick look at your merged patches and thought that stmmac_xpcs_setup() had been repurposed in the meantime, but it seems like I was just confused about that. > It doesn't look as that much hard thing to do, but will cause having a > better readable code by providing a single coherent function for all > PCS'es. Sure, I'll get to it in v5. Thanks, -- Romain Gantois, Bootlin Embedded Linux and Kernel engineering https://bootlin.com