From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752583AbcBHKAn (ORCPT <rfc822;w@1wt.eu>);
	Mon, 8 Feb 2016 05:00:43 -0500
Received: from mout.kundenserver.de ([212.227.17.24]:54042 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751098AbcBHKAl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 8 Feb 2016 05:00:41 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
        Ley Foon Tan <lftan@altera.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Stanimir Varbanov <svarbanov@mm-sol.com>,
        Thierry Reding <thierry.reding@gmail.com>, linux-pci@vger.kernel.org,
        linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 5/5] drivers/pci: make most of the PCI_DW drivers modular
Date: Mon, 08 Feb 2016 11:00:27 +0100
Message-ID: <2730150.DUniNa63fK@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1454889644-27830-6-git-send-email-paul.gortmaker@windriver.com>
References: <1454889644-27830-1-git-send-email-paul.gortmaker@windriver.com> <1454889644-27830-6-git-send-email-paul.gortmaker@windriver.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:8g7xW3fS31oTcXX8Bjf8fizV/I+CRc6ompk0AMkki3mOSmlIewW
 9Yocaftsa/hODuUMKy4BuPkNxgLjvc+KypIBpHqteGmGf97E9n7DHOJ2V4uKZXRcJsJ+imN
 tIDCWKXBgmaofH7Hr18PuRiSq2yHQO12OTiJHT2OGI2WLQpzq2LxqnuUqkPkwMHYvIrjTMG
 fI4XEoJBCriAwArFa8zJw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:J7+WyS4rfwk=:tuF4fBZ893QS7Hve7MDXlW
 6zdtDalufMmCJ2y7Aw/eA4Jj4UOBTXBOWJPNkCe3h/czvtF6Y4GNtn5OCgDCnDSsyYE0Ob7ka
 P9tITW8hOwPYvuhJp8QSS4WHE846lqH7darbnwWapAOZ6l6DUffi5eKq6gfjZoXh10meNjLb5
 a7oteG7J0rlG2B29Jxtkf/YmlXR2HMdyZUv+gWQwmTKAtjW29PoJKP0HyoMZbvaJML8fbj11z
 MZ9h1IU2Y9GwalHYUP/ke/ihXPzFZLI5c6zHgYzpTVmyPsZ4HHP8khKVLkJXhKycpxB/Xbqlr
 lMxFk/akpxUL+869G5SNj3N0nTusyu1ORGzSKC/Wwz7hD0Z01VIbYXI833Z5yvSmDwiQZax7G
 7kt+v/gZaZmvf2cikDG3K0XY0HQwhYBkv46cGVOCYjghn7CW04+lUz/WVDKfbg4ClsBKglOf/
 PrzfT8WsIBjBXvByKAzRW8thPC2ZReMPrTgui2T23VSL/zvv8R2P6+1cd1E9Rmg4DBQ9nEWeH
 ipCCgCBk1fT/IRpwyKrGR6aDHUhfq5ZpMqKbdBjPrOCPy4UvVdx0iKYYSyFm3BqtY4w0uT8iS
 ar/QiUNNLMYRyXTqnm/nTd+f/lv8gaCWGPXUGLPaw753OFkx1X8MFy0z7/XnJrFlH12BCH4Mj
 T6ml8q4tEU9yHhu24qI31TrV1WNZu5I6mgd1buP1E9LMKsleMliBjBMbClSZSSGkY8NWVt8OI
 LjTd2urVIiiIgfnp
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sunday 07 February 2016 19:00:44 Paul Gortmaker wrote:
> We've exported the symbols that we know these specific drivers
> will need as tristate, so now we can make the conversion from
> bool to tristate w/o concern for build regressions.
> 
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Ley Foon Tan <lftan@altera.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Stanimir Varbanov <svarbanov@mm-sol.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: linux-pci@vger.kernel.org
> Cc: linux-arm-msm@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Looks good, but I'm not sure what happens on unload. Did you check?
Until this is tested, maybe it's best to prevent module unloading?

	Arnd