From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755526AbcETKAW (ORCPT ); Fri, 20 May 2016 06:00:22 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:55898 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753936AbcETKAS (ORCPT ); Fri, 20 May 2016 06:00:18 -0400 From: Arnd Bergmann To: Petko Manolov Cc: "David S. Miller" , "xypron.glpk@gmx.de" , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, oneukum@suse.com, linux@roeck-us.net Subject: Re: [PATCH] net: pegasus: remove unused variables and labels Date: Fri, 20 May 2016 11:58:47 +0200 Message-ID: <2736625.RvDzKBHoOP@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160520093223.GJ21813@p310> References: <1463732595-3149399-1-git-send-email-arnd@arndb.de> <20160520093223.GJ21813@p310> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:6XvwGk0LsYO914TF0/chfKYCZKRxICRPnGLJqx/fDMinn3NpM1a oO4A4VH3D+ggmzilGmVCHBilKiiPZUjsGS/WJYognk9gX5V6y9b4HDA4Ww8tdo5mr/F29v3 RD4yE9Lc3PvIggqtoEr9QqAToUV7YJXFdPow4Eusetb04Ye89aNLs1gI/ZACu83pPCvIbCT 9tyYioGEoiZqYU+zGLjIw== X-UI-Out-Filterresults: notjunk:1;V01:K0:CQlrccsVShA=:OBG8Vf7SRCWq3WsHoQpnOp fYqVlvOIUbfZcgyG16UW+gk12Vni9EVr7P5D2per6RmCB/EUHAXc8cZTe5nCjlotGmJBgwbhz usa/XWCeUKbkECLN8Xj6kLuHigIFT6lQHt8DH/3wllKPk0Mpil39EVvwuqFJBBC24v9r9ND2s 02BnwI1jcmh9vLIX5C2cl/hN69EVJ7bTKPD1hNAhEdbuu7UwOjmVs22kuhd8lV9X98nKr+YFA 42qrTvviVqsqeK0bs/VxYhSYg0UNCrMdBxvCAQXza0mo+pjG15FsoKGOpcY93ePHRPk0AOavR We6/hHjwHkqkLUWvyFBPWFOd+ApKY4R9h7ft2r3UjRdr8rp0EF4eveBiz2jouPVCqNQ8ox3wi HBluxKOlu45w12hxw4ZfNqJa9/YRGJG24Xa6bfkQOmJZIZLa3Xw2wFkUg2Mt+TEi6R/yQJAas B30Vlwx85QsMmKhfuy7THGDVM1bhARFt6QcJDbCPwqZVGJyteV4NXOsxlsKu2OpwhmiqQu2V/ mDRlh8dD3JrX9bY+gjV628g1xDZTV2ozXG6VCjZTIIkMZVMrKpbVsvJttVqaT54up8VfHw85Z lBU0Clxfb2OG6nrAnk5rbrWmTy9/1qrYRB0FDm/OXmd1o/08j8oeWJw7oF77UKFeJ9RqaApKY JRCibWfbSuIsRkkkmz+ZwafmeGRAVGG4uMcy/5ACWTP8pIn/G4QYSZpYdKlblZgu7ZIMWhGM9 WiZgsmdJkFQFLhBqKZU4qGb5vMqQw3k2cbgQYA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 20 May 2016 12:32:23 Petko Manolov wrote: > Guys, come on. This code is not dead. This code is executed every time an > ethernet packet is received. It takes care of various error statistics. More > importantly, it sends the actual (reported by the adapter) packet length to the > network layer along with the packet. > > This patch removes skb_put() and netif_rx() calls and effectively kills the RX > path. Not to mention that the driver was not even compiled before sending the > patch upstream. > > The only sensible, although cosmetic, change would be to replace: > > if (!count || count < 4) > > with > > if (count < 4) > > even though GCC takes care and it optimizes away "!count" condition. > > Please revert this patch before Linus pulls from the network tree. > Agreed. I failed to check the commit that introduced the warning for the more serious problem. Please revert e00be9e4d0ff, it just makes no sense. Arnd