From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4724FC001DB for ; Fri, 11 Aug 2023 10:29:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234809AbjHKK3J (ORCPT ); Fri, 11 Aug 2023 06:29:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230230AbjHKK3G (ORCPT ); Fri, 11 Aug 2023 06:29:06 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1070DDC; Fri, 11 Aug 2023 03:29:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691749746; x=1723285746; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=1cuNBVAHm1eCW8DM16u/EOGsWYmWOHNYNDUo0LaepRQ=; b=QEqaV9xjcgjdYS5Z5NcrsdsYrg6UzKrFhdTAkjBNq1bKPTmTibDeyUOs DXK1JEWQxW5ybtNpxPwS92YmdKTGsXP4F+g+0cL8M9CcSJjtABBn54jbT o9Nszfe7agb2m7RGfSCbObCPkIM210umbbJq4Dh6PRvwS/F35OYZeJhE3 3EYw0hfc9Hi/czYaD9Q3ZGhONze/VaamqGLOrnC83N4C91EOceqJuK1EY bNy2454kYmnZL3dwfl1Fkd1QM5l7xHnG6d4Qi4Uvyh709xIFfuWwqpCci d2u1/SL0kglnLeKjBoGxEMxteplLr5sItTdWDjKe9Xl9i8EVIVQlDQwNi Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="351250401" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="351250401" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2023 03:29:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="822620171" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="822620171" Received: from aberko-mobl1.ger.corp.intel.com ([10.252.51.87]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2023 03:28:59 -0700 Date: Fri, 11 Aug 2023 13:28:56 +0300 (EEST) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: "Jiri Slaby (SUSE)" cc: Greg Kroah-Hartman , linux-serial , LKML , William Hubbs , Chris Brannon , Kirk Reiser , Samuel Thibault , Dmitry Torokhov , Arnd Bergmann , Max Staudt , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Dario Binacchi , Andreas Koensgen , Jeremy Kerr , Matt Johnston , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Peter Ujfalusi Subject: Re: [PATCH 16/36] tty: use u8 for chars In-Reply-To: <20230810091510.13006-17-jirislaby@kernel.org> Message-ID: <27366cad-30b2-e326-8d8f-c6fe17cf4899@linux.intel.com> References: <20230810091510.13006-1-jirislaby@kernel.org> <20230810091510.13006-17-jirislaby@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Aug 2023, Jiri Slaby (SUSE) wrote: > This makes all those 'unsigned char's an explicit 'u8'. This is part of > the continuing unification of chars and flags to be consistent u8. > > This approaches tty_port_default_receive_buf(). Flags to be next. > > Signed-off-by: Jiri Slaby (SUSE) > Cc: William Hubbs > Cc: Chris Brannon > Cc: Kirk Reiser > Cc: Samuel Thibault > Cc: Dmitry Torokhov > Cc: Arnd Bergmann > Cc: Max Staudt > Cc: Wolfgang Grandegger > Cc: Marc Kleine-Budde > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: Dario Binacchi > Cc: Andreas Koensgen > Cc: Jeremy Kerr > Cc: Matt Johnston > Cc: Liam Girdwood > Cc: Mark Brown > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: Peter Ujfalusi > --- > drivers/accessibility/speakup/spk_ttyio.c | 5 ++-- > drivers/input/serio/serport.c | 5 ++-- > drivers/misc/ti-st/st_core.c | 2 +- > drivers/net/can/can327.c | 2 +- > drivers/net/can/slcan/slcan-core.c | 5 ++-- > drivers/net/hamradio/6pack.c | 4 ++-- > drivers/net/hamradio/mkiss.c | 2 +- > drivers/net/mctp/mctp-serial.c | 3 +-- > drivers/net/ppp/ppp_async.c | 8 +++---- > drivers/net/ppp/ppp_synctty.c | 11 ++++----- > drivers/net/slip/slip.c | 2 +- > drivers/tty/n_gsm.c | 2 +- > drivers/tty/n_hdlc.c | 2 +- > drivers/tty/n_tty.c | 28 +++++++++++------------ > drivers/tty/tty.h | 2 +- > drivers/tty/tty_buffer.c | 21 ++++++++--------- > include/linux/tty_buffer.h | 4 ++-- > include/linux/tty_flip.h | 22 ++++++++---------- > include/linux/tty_ldisc.h | 18 +++++++-------- > sound/soc/codecs/cx20442.c | 4 ++-- > sound/soc/ti/ams-delta.c | 2 +- > 21 files changed, 73 insertions(+), 81 deletions(-) > diff --git a/include/linux/tty_buffer.h b/include/linux/tty_buffer.h > index 6ceb2789e6c8..6f2966b15093 100644 > --- a/include/linux/tty_buffer.h > +++ b/include/linux/tty_buffer.h > @@ -22,9 +22,9 @@ struct tty_buffer { > unsigned long data[]; > }; > > -static inline unsigned char *char_buf_ptr(struct tty_buffer *b, int ofs) > +static inline u8 *char_buf_ptr(struct tty_buffer *b, int ofs) > { > - return ((unsigned char *)b->data) + ofs; > + return ((u8 *)b->data) + ofs; > } Any particular reason why b->data is left unsigned long? -- i.