From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752460AbdCNOrv (ORCPT ); Tue, 14 Mar 2017 10:47:51 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:49733 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785AbdCNOqV (ORCPT ); Tue, 14 Mar 2017 10:46:21 -0400 X-AuditID: b6c32a59-f79736d000001328-07-58c80235346c From: Bartlomiej Zolnierkiewicz To: Krzysztof Kozlowski Cc: Kishon Vijay Abraham I , Kukjin Kim , Javier Martinez Canillas , Lee Jones , Sylwester Nawrocki , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v2 4/4] phy: exynos: Use one define for enable bit Date: Tue, 14 Mar 2017 15:46:10 +0100 Message-id: <2746282.jBJ7tRjldv@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170311182534.13345-5-krzk@kernel.org> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOKsWRmVeSWpSXmKPExsWy7bCmhq4p04kIg9Y97BZv3q5hsuh//JrZ 4sLTHjaL8+c3sFvc/3qU0WLT42usFpd3zWGzmHF+H5PF4TftrA6cHptWdbJ53Lm2h81j85J6 jy39d9k9+rasYvQ4fmM7k8fnTXIB7FFcNimpOZllqUX6dglcGau/fWAreM9VceRsA1sD43uO LkZODgkBE4l1zw6xQdhiEhfurQeyuTiEBJYySpyZO4EJwmlnktj7dQEzTMeNxt/sEInljBLv rp1nhXC+MkrsvfMebBabgJXExPZVjCC2iICmxPW/31lBbGaBXUwST9aWg9jCAm4Sd77uAouz CKhKXDk8mwXE5gWq3925FiwuKuAlsWVfOxOIzSlgKjHl/RI2iBpBiR+T77FAzJSX2Ld/KtR8 HYmzx9YxghwkIXCIXaKpbT5QggPIkZXYdADqAxeJR5P3MUHYwhKvjm9hh7ClJf4uvcUIYU9n lNj+WwJizmZGiVW7J0AVWUscPn4RahmfRO/vJ0wQ83klOtqEIEo8JCasmwo131Fi9pRf0NAC mtP0ezrzBEb5WUh+mIXkh1lIfljAyLyKUSy1oDg3PbXYtMBUrzgxt7g0L10vOT93EyM4+WhF 7mC8MjPoEKMAB6MSD++GT8cjhFgTy4orcw8xSnAwK4nwvmY4ESHEm5JYWZValB9fVJqTWnyI UZqDRUmcN8pgYoSQQHpiSWp2ampBahFMlomDU6qBUUd8/ZOmE4LuSif85cT8rsj/Omo6e9ai gsBvj41tTU8a3fFk6Nx2h91YeuGGiMXMG8I/nCw0nFPN6d+xMZjn+LJwE4dtiRH+znkxcyrW 5e7a2dNx6Kt7/ZKNPQd9nv5cU70kWnfG0kOzTyv0akxg2bS2jCHD6ZZyYr71DPMe1UUrNj56 ebvFV4mlOCPRUIu5qDgRAEMJDXo6AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBIsWRmVeSWpSXmKPExsVy+t9jAV0TphMRBvM3aVm8ebuGyaL/8Wtm iwtPe9gszp/fwG5x/+tRRotNj6+xWlzeNYfNYsb5fUwWh9+0szpwemxa1cnmcefaHjaPzUvq Pbb032X36NuyitHj+I3tTB6fN8kFsEe52WSkJqakFimk5iXnp2TmpdsqhYa46VooKeQl5qba KkXo+oYEKSmUJeaUAnlGBmjAwTnAPVhJ3y7BLWP1tw9sBe+5Ko6cbWBrYHzP0cXIySEhYCJx o/E3O4QtJnHh3nq2LkYuDiGBpYwSnzZsYYFwvjJKNLzvZwSpYhOwkpjYvgrMFhHQlLj+9zsr SBGzwC4micktD9lAEsICbhJ3vu5iBbFZBFQlrhyezQJi8wI17O5cCxYXFfCS2LKvnQnE5hQw lZjyfglQLwfQtniJw1eqIMoFJX5MvgfWyiwgL7Fv/1RWCFtLYv3O40wTGAVmISmbhaRsFpKy BYzMqxglUguSC4qT0nON8lLL9YoTc4tL89L1kvNzNzGCY/GZ9A7Gw7vcDzEKcDAq8fBu+HQ8 Qog1say4MvcQowQHs5II7+WvQCHelMTKqtSi/Pii0pzU4kOMpkD/TWSWEk3OB6aJvJJ4QxNz E3NjAwtzS0sTIyVx3sbZz8KFBNITS1KzU1MLUotg+pg4OKUaGJd1v5y8+HB84zc3tx/3uiZG zf98z0nmjUtNhm5r56McfttXlx0zT69vUqmcfJp9Ue3S3phQKzHWjTu9lzm7rt79aOP57J7n 0vma6t99k62OWmnG7n73NjY3a/enRW6Za2cp/JAJ7QziEDn9YNPWXqfYif0Z9T2LGqWD2wQr o9iOXiq7cvDZRCWW4oxEQy3mouJEAPSW9LLbAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170314144612epcas5p43922a86ea62ef32bc8e32dc27f5164ab X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170314144612epcas5p43922a86ea62ef32bc8e32dc27f5164ab X-RootMTR: 20170314144612epcas5p43922a86ea62ef32bc8e32dc27f5164ab References: <20170311182534.13345-1-krzk@kernel.org> <20170311182534.13345-5-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Saturday, March 11, 2017 08:25:34 PM Krzysztof Kozlowski wrote: > There is no need for separate defines for Exynos4 and Exynos5 phy enable > bit and MIPI phy reset bits. In both cases there are the same so > simplify it. > > This reduces number of defines and allows removal of one header file. > > Signed-off-by: Krzysztof Kozlowski > Acked-by: Lee Jones > --- > drivers/phy/phy-exynos-dp-video.c | 5 ++-- > drivers/phy/phy-exynos-mipi-video.c | 39 ++++++++++++++--------------- > drivers/phy/phy-exynos5-usbdrd.c | 5 ++-- > include/linux/mfd/syscon/exynos5-pmu.h | 22 ---------------- > include/linux/soc/samsung/exynos-regs-pmu.h | 3 ++- > 5 files changed, 25 insertions(+), 49 deletions(-) > delete mode 100644 include/linux/mfd/syscon/exynos5-pmu.h [...] > --- a/include/linux/mfd/syscon/exynos5-pmu.h > +++ /dev/null > -#define EXYNOS5433_PAD_RETENTION_AUD_OPTION (0x3028) > -#define EXYNOS5433_PAD_INITIATE_WAKEUP_FROM_LOWPWR BIT(28) EXYNOS5433_PAD_INITIATE_WAKEUP_FROM_LOWPWR is not defined in and is still used by drivers/mfd/exynos-lpass.c (at least in next-20170310) Do I miss something or it needs to be fixed? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics