Re: [PATCH] nvme-pci: drop redundant pci_enable_pcie_error_reporting()

[Chaitanya Kulkarni <chaitanyak@nvidia.com>]

On 3/7/23 12:32, Bjorn Helgaas wrote:

> From: Bjorn Helgaas <bhelgaas@google.com>
>
> pci_enable_pcie_error_reporting() enables the device to send ERR_*
> Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
> native"), the PCI core does this for all devices during enumeration, so the
> driver doesn't need to do it itself.
>
> Remove the redundant pci_enable_pcie_error_reporting() call from the
> driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
> from the driver .remove() path.
>
> Note that this only controls ERR_* Messages from the device.  An ERR_*
> Message may cause the Root Port to generate an interrupt, depending on the
> AER Root Error Command register managed by the AER service driver.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---

Indeed it is moved to pci_aer_init(), and will get called
from :-
pci_scan_single_device()
  pci_device_add()
   pci_init_capabalities()
    pci_aer_init()

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck