From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966077AbcA1IuH (ORCPT ); Thu, 28 Jan 2016 03:50:07 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:54758 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965173AbcA1IuF (ORCPT ); Thu, 28 Jan 2016 03:50:05 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Paul Gortmaker , Rasesh Mody , netdev@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-kernel@vger.kernel.org, Rajesh Borundia , Michael Chan , "David S. Miller" Subject: Re: [PATCH 3/9] net: bgmac: clarify CONFIG_BCMA dependency Date: Thu, 28 Jan 2016 09:49:15 +0100 Message-ID: <2754981.4bUSE7NdJb@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160127161110.GL8889@windriver.com> References: <1453903507-3427225-1-git-send-email-arnd@arndb.de> <1453903507-3427225-4-git-send-email-arnd@arndb.de> <20160127161110.GL8889@windriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:+oTXwo9Qg8AX94l5hgJLJhTNkDAsGoZFKZX0fjP5IPf4Eek4WSU s10kBsO9jaqHaT7wXUVCt+4GN7rje0H5LT4Zpiyx/Sv3OoLsBsjspVbLrt+lzd1Vk6r4Zol F2OnQQPqCFqECofKRzfdk9CAO0hy/YuVj+b0pCTRejNT8LMSzaemI9OjldeJ+KaIQkXMi0G pq6n1qG+HoczWZhDhk7tg== X-UI-Out-Filterresults: notjunk:1;V01:K0:pRtyK+5+yvo=:IxfeNgdNyhq5Rc4FjiNgF+ 6MraEU90XH/P4h2gZj0gRMuqf97E1u+VH38iFYzDEEvu3sisa/ElRwrsAavQPr23kEnDyUEIZ X6zNpDSKPcAAQkiuZ0QNpxkCjKGvbBmG4IOq71dUv0ODb7OEI9C0WnAAePAhnMAudmgN+ZhM1 8Jd/KzECuxyFI6t16H5xgBWnk5V0t52hlmWodeP37FF4w571hmfRLZxwZd2lnOy00zQfi2DH4 AIDytgg0C98MABXDwlrHB+croVgaxqmSMnYzAOqV/FtBBNl97Zx/AJ7AhMyAZpcl9zfW7ZsCP HlmFDGZC1DOoq29sdLyx+KuwHJidGtqY1nohSMZFTnf9eTrTzCn3B6/M2O0AFggy95OQfx/u1 sI/SbcOFgaHFf2Uf5/TugXgc8Y/me8jrrWYoEuu08YlsCPKQ/QglV2fS/1LVgfOTJ8Erx1lyb N1jzmlmHgZ6UgFjWhEq6lA6CNY6io89/lYa1yZBjwTrzB4jHSAQeO+37Y/Udwajp5FTe3HtAO mSbCo13I55F/7w74zr2YMwAi/apXSyQxFj32siBG420CmWPa4cobF03KGHjglAs9C+EKbMK48 nIcm09ZTgaoqmqAmzobJbUG4trrHpFGfG2RIfmdD2kx7Zamtg+Vu6jXUOrAtUbx6om6CmZA5J Ur74ISK4meJG765M2rwQSSC4C8zuakNqUz5Aa3XPTd85eBJshBPweizkCC4ZrDc2nIZ+jUBLY XF+xbwWL9iU29uj5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 27 January 2016 11:11:10 Paul Gortmaker wrote: > [[PATCH 3/9] net: bgmac: clarify CONFIG_BCMA dependency] On 27/01/2016 (Wed 15:04) Arnd Bergmann wrote: > > > The bgmac driver depends on BCMA_HOST_SOC, which is only used > > when CONFIG_BCMA is enabled. However, it is a bool option and can > > be set when CONFIG_BCMA=m, and then bgmac can be built-in, leading > > to an obvious link error: > > > > drivers/built-in.o: In function `bgmac_init': > > :(.init.text+0x7f2c): undefined reference to `__bcma_driver_register' > > drivers/built-in.o: In function `bgmac_exit': > > :(.exit.text+0x110a): undefined reference to `bcma_driver_unregister' > > > > To avoid this case, we need to depend on both BCMA and BCMA_SOC, > > as this patch does. I'm also trying to make the dependency more > > readable by splitting it into three lines, and adding a COMPILE_TEST > > alternative so we can test-build it in all configurations that > > support BCMA. > > It wasn't immediately clear to me from the above why you added the > select on FIXED_PHY. > Right, I'll resend the patch with improved changelog. This series is mostly patches for old and rare randconfig bugs, so I had built thousands of configurations and fixed up everything until new warnings or errors kept coming up. The FIXED_PHY error came up in the same driver so I merged the two patches but did not notice how the changelog failed to explain it. Thanks, Arnd