From: Valdis.Kletnieks@vt.edu
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
linux-kernel@vger.kernel.org,
linux-pm@lists.linux-foundation.org
Subject: Re: mmotm 2010-07-01 pm_get_wakeup_count() declaration
Date: Mon, 05 Jul 2010 22:24:35 -0400 [thread overview]
Message-ID: <2755.1278383075@localhost> (raw)
In-Reply-To: Your message of "Mon, 05 Jul 2010 22:43:55 +0200." <201007052243.55551.rjw@sisk.pl>
[-- Attachment #1: Type: text/plain, Size: 1445 bytes --]
On Mon, 05 Jul 2010 22:43:55 +0200, "Rafael J. Wysocki" said:
> On Monday, July 05, 2010, Valdis.Kletnieks@vt.edu wrote:
> > On Thu, 01 Jul 2010 12:19:51 PDT, akpm@linux-foundation.org said:
> > > The mm-of-the-moment snapshot 2010-07-01-12-19 has been uploaded to
> >
> > Not sure who to blame for the commit, it was in the linux-next.patch and I'm
> > too lazy to pull down the git tree and dig it out.
> >
> > CC kernel/power/main.o
> > kernel/power/main.c: In function 'wakeup_count_show':
> > kernel/power/main.c:241: error: implicit declaration of function 'pm_get_wakeup_count'
> > kernel/power/main.c: In function 'wakeup_count_store':
> > kernel/power/main.c:251: error: implicit declaration of function 'pm_save_wakeup_count'
> > make[2]: *** [kernel/power/main.o] Error 1
> >
> > Problem is that declaration in include/linux/suspend.h is wrapped in
> > a #ifdef CONFIG_PM_SLEEP, but the usage in kernel/power/main.c isn't. So
> > it dies a horrid death if your config doesn't include PM_SLEEP.
>
> Yeah, sorry. I'm in the process of fixing it up.
I threw in some ad-crock #ifdef to get past that one, and hit
another one, same basic issue but include/linux/pm.h this time:
CC drivers/base/power/sysfs.o
drivers/base/power/sysfs.c: In function 'wakeup_count_show':
drivers/base/power/sysfs.c:152: error: 'struct dev_pm_info' has no member named 'wakeup_count'
make[3]: *** [drivers/base/power/sysfs.o] Error 1
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2010-07-06 2:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 19:19 mmotm 2010-07-01-12-19 uploaded akpm
2010-07-01 23:28 ` mmotm 2010-07-01-12-19 uploaded (mmc) Randy Dunlap
2010-07-07 21:36 ` Andrew Morton
2010-07-02 9:26 ` mmotm 2010-07-01-12-19 uploaded Xiaotian Feng
2010-07-02 18:24 ` Andrew Morton
2010-07-03 1:24 ` [PATCH -mmotm] 8250_early: fix printk format warnings Randy Dunlap
2010-07-08 18:37 ` Greg KH
2010-07-08 18:45 ` Randy Dunlap
2010-07-08 18:55 ` Greg KH
2010-07-09 5:47 ` KOSAKI Motohiro
2010-07-09 22:46 ` Andrew Morton
2010-07-12 1:18 ` KOSAKI Motohiro
2010-07-12 2:25 ` Randy Dunlap
2010-07-05 20:35 ` mmotm 2010-07-01 pm_get_wakeup_count() declaration Valdis.Kletnieks
2010-07-05 20:43 ` Rafael J. Wysocki
2010-07-06 2:24 ` Valdis.Kletnieks [this message]
2010-07-06 18:06 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2755.1278383075@localhost \
--to=valdis.kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox