linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: x86@kernel.org, kvm@vger.kernel.org
Cc: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Avi Kivity <avi@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	gleb@redhat.com, Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCHv2 2/7] apic: use symbolic APIC_EOI_ACK
Date: Fri, 11 May 2012 10:38:10 +0300	[thread overview]
Message-ID: <27551cdee554eabd26b8c18cd29d9caaaaa6c788.1336679924.git.mst@redhat.com> (raw)
In-Reply-To: <cover.1336679924.git.mst@redhat.com>

Use the symbol instead of hard-coded numbers,
now that the reason for the value is documented
where the constant is defined we don't need to
duplicate this explanation in code.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 arch/x86/include/asm/apic.h |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h
index d854101..a09e9ab 100644
--- a/arch/x86/include/asm/apic.h
+++ b/arch/x86/include/asm/apic.h
@@ -463,9 +463,7 @@ static inline void ack_APIC_irq(void)
 	 * ack_APIC_irq() actually gets compiled as a single instruction
 	 * ... yummie.
 	 */
-
-	/* Docs say use 0 for future compatibility */
-	apic_write(APIC_EOI, 0);
+	apic_write(APIC_EOI, APIC_EOI_ACK);
 }
 
 static inline unsigned default_get_apic_id(unsigned long x)
-- 
MST


  parent reply	other threads:[~2012-05-11  7:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1336679924.git.mst@redhat.com>
2012-05-11  7:38 ` [PATCHv2 1/7] apic: fix typo EIO_ACK -> EOI_ACK and document Michael S. Tsirkin
2012-05-11  7:38 ` Michael S. Tsirkin [this message]
2012-05-11  7:38 ` [PATCHv2 3/7] x86: add apic->eoi_write callback Michael S. Tsirkin
2012-05-11  7:38 ` [PATCHv2 4/7] x86: eoi micro-optimization Michael S. Tsirkin
2012-05-11  7:38 ` [PATCHv2 5/7] kvm_para: guest side for eoi avoidance Michael S. Tsirkin
2012-05-11  7:38 ` [PATCHv2 6/7] x86/bitops: note on __test_and_clear_bit atomicity Michael S. Tsirkin
2012-05-11  7:38 ` [PATCHv2 7/7] kvm: host side for eoi optimization Michael S. Tsirkin
2012-05-13  9:33   ` Gleb Natapov
2012-05-13 10:01     ` Michael S. Tsirkin
2012-05-13 10:04       ` Gleb Natapov
2012-05-13 15:15     ` Michael S. Tsirkin
2012-05-11  7:43 ` [PATCH] qemu: whitelist kvm pv eoi feature Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27551cdee554eabd26b8c18cd29d9caaaaa6c788.1336679924.git.mst@redhat.com \
    --to=mst@redhat.com \
    --cc=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).