From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755478Ab2EKHiM (ORCPT ); Fri, 11 May 2012 03:38:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45193 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751215Ab2EKHiJ (ORCPT ); Fri, 11 May 2012 03:38:09 -0400 Date: Fri, 11 May 2012 10:38:10 +0300 From: "Michael S. Tsirkin" To: x86@kernel.org, kvm@vger.kernel.org Cc: Ingo Molnar , "H. Peter Anvin" , Avi Kivity , Marcelo Tosatti , gleb@redhat.com, Linus Torvalds , linux-kernel@vger.kernel.org Subject: [PATCHv2 2/7] apic: use symbolic APIC_EOI_ACK Message-ID: <27551cdee554eabd26b8c18cd29d9caaaaa6c788.1336679924.git.mst@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mutt-Fcc: =sent Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the symbol instead of hard-coded numbers, now that the reason for the value is documented where the constant is defined we don't need to duplicate this explanation in code. Signed-off-by: Michael S. Tsirkin --- arch/x86/include/asm/apic.h | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h index d854101..a09e9ab 100644 --- a/arch/x86/include/asm/apic.h +++ b/arch/x86/include/asm/apic.h @@ -463,9 +463,7 @@ static inline void ack_APIC_irq(void) * ack_APIC_irq() actually gets compiled as a single instruction * ... yummie. */ - - /* Docs say use 0 for future compatibility */ - apic_write(APIC_EOI, 0); + apic_write(APIC_EOI, APIC_EOI_ACK); } static inline unsigned default_get_apic_id(unsigned long x) -- MST