From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934033AbcIVO2e (ORCPT <rfc822;w@1wt.eu>);
        Thu, 22 Sep 2016 10:28:34 -0400
Received: from mail-pf0-f194.google.com ([209.85.192.194]:34529 "EHLO
        mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933209AbcIVO2d (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 22 Sep 2016 10:28:33 -0400
Subject: Re: [PATCH] clocksource: timer-imx-gpt: Unmap and free region
 obtained by of_iomap and kzalloc
To: Thomas Gleixner <tglx@linutronix.de>
References: <1474553366-8400-1-git-send-email-arvind.yadav.cs@gmail.com>
 <alpine.DEB.2.20.1609221608490.5599@nanos>
Cc: daniel.lezcano@linaro.org, vincent.guittot@linaro.org,
        linux-kernel@vger.kernel.org
From: arvind Yadav <arvind.yadav.cs@gmail.com>
Message-ID: <2758043c-44a8-2217-3e3c-28e16b503c16@gmail.com>
Date: Thu, 22 Sep 2016 19:58:28 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1609221608490.5599@nanos>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

I have changed  subject as per your review comment.

thanks,

     -Arvind


On Thursday 22 September 2016 07:46 PM, Thomas Gleixner wrote:
> On Thu, 22 Sep 2016, Arvind Yadav wrote:
>
>> Subject: clocksource: timer-imx-gpt: Unmap and free region obtained by of_iomap and kzalloc
> These subject lines are useless and way too long. A patch subject should
> describe the nature of the patch and not elaborate what the patch is doing
> technically.
>
>     clocksrouce/timer-imz-gpt: Prevent resource leaks in error path
>
> would be a proper subject line which makes it entirely clear what this
> patch is about.
>
>  From your subject line I have to read the patch itself to figure that
> out. It's completely irrelevant whether that resource is a mapping or
> allocated memory. The point is that the error path leaks resource(s).
>
> See Documentation/SubmittingPatches. There you'll find a lengthy
> explanation about changelogs and summary lines in particular.
>
> Thanks,
>
> 	tglx
>
>
>