From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABA9C30DEAF for ; Mon, 24 Nov 2025 14:08:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763993299; cv=none; b=k342sdu46+RHMMqt3gCI6WxRpxMtWzHK95t33dLOn96pmaXf5hEhdNQIOVvEN6egh930xmSPTTlNVY3/xPAxfcd7O1/zum+8PCLN6xh8crQnub+SAvPaTuPjFfSC21WaY4w5p+mdgFLz5ku8uNdAdmqQEf/9MijC71Uubf7pviw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763993299; c=relaxed/simple; bh=7YKZHAFhDcKEqQAk+JIlZdMiyf/pZyD+Q6/FfKHi1Ww=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iLyg+H7he3As9C+ptcz8deSAPqeTn4LP6YZ6LC8+tVJb6ssURFU0Zr9sHrV+BEHxH4ESZ6srqOknK4wWuHxoINjzitsvsLzC24lU7110M3g5Uicjalma8KPFu/QQroFZRdcYrBl3InBda78T4tbwjzuPTFujd5+P0svxNjp1cV0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GzzHWQMk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QTC5hf9A; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GzzHWQMk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QTC5hf9A" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AOB5guJ4003037 for ; Mon, 24 Nov 2025 14:08:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6QQ62ZxwkhlLfH9i4OuMkYuxp6Si/5CSoyIHKynyDww=; b=GzzHWQMkOfXzoZ/8 DWoEejCz4IKvwaydAIsdv63NQBHaFywbDJArjxMWZsS9lPbls2Bb1QqfdfO5/Zyq AVbEsZnSKX9Bfr73eWWqfDdLVuDUQEJ+dwgNZDMaeBbabdN6/zW3EXiwd1vJHC5I iLEOFb2u5ebwuEZ92psnAIi/HU1jKeiSaKezgSfpAjccKTyXLOGGcUWyEoH7Seoj okWEVDKF5ytiiNH339b7Ym4I5x5QLWbJyZjMvBjGTg4y7D3Xo8dS5UfH7tMa4829 fujmKgTy7L6qgNtYUdRpSjc4iNWeqXTP3Qp+c0iRhzlopmqBK4lR03m79mQGkRqS 3X2p5w== Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4amp6h0f9n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 24 Nov 2025 14:08:16 +0000 (GMT) Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-9371fb858afso2696394241.3 for ; Mon, 24 Nov 2025 06:08:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763993295; x=1764598095; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6QQ62ZxwkhlLfH9i4OuMkYuxp6Si/5CSoyIHKynyDww=; b=QTC5hf9ApdqnJrgi4RpyyZ6nT6ovvqwgetwEGD39Wt2amwSo35RsMJU1eEPckyb5UL 7/+Bpob+xrx64OWjvUMIXReBBM4FOX3UGnG7DXn/cnaiTyCBsjp+gPuIlxCa2psUU3HN SS6BOum/sB+ho2tUp+wKr4rJhQ03yFwqkGkEEAG33WWrXHUCdm8iqw+4hNZhTXZCnGWO 7gOmEGi7QGQSwTrZ5fICst7lkC5RUwUhcJSxxc0AePNRIY9RXqoLuQRyLG0cbijrWuPN yIAQeCBC+zBZI3hZBmOs1CSnzpzVipjTNFmfKaqVUTlTl8S+5Ho5VhEh/Cgrcn+ghLxB FI6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763993295; x=1764598095; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6QQ62ZxwkhlLfH9i4OuMkYuxp6Si/5CSoyIHKynyDww=; b=Lo14Fpw3WeSw8MrJDY0+cq89rkmZ35X9boHjcowY29IZi+WNgeT9RuhognKj/5uU2w vikLZ0lBYnGOXeW2WbVAiIp44QccY64GcEgjj2XL7Nt+s1QsewrT62nrI6CYRVTvYDub zVT/GBDvrSAJCH5htBjhla2nPbu0M9RZbjIb+Ggn4QNNOKQM38Ueq/nxiVfsaauTx2Oy ldpJdDtHCguuRtJpSkyP7R9gN93PDfCOMd9x3PMZKz2qV09+to9gm/AEuwsPsomkpnB7 gQ26JXoyt9Jl7BW+gCfbyCZysP2xxnXNmYxXcFf/QMAmkdfgyFbCM7I1c/ErTYMYpyLt e9/Q== X-Forwarded-Encrypted: i=1; AJvYcCUaH26n4X9Zh5W0T9IlHSJNJkavgiXJauMpeLX5UETGA9kT48ozcjCWOUGDr6Ckv3SeROizDJ641/6eUMc=@vger.kernel.org X-Gm-Message-State: AOJu0YxuRhos1IPpDvMRZF1P8mA70clDxYi7Xa3DoXV/W8odBi6PnU4N O9yMxHCdsN0GMF/KHhDYootigI4SAapp4YjMMTSYR02RN22ZVuqevpsG/NPAv6YGt62RuH/iVSX 0enkZTrnOeaOb4hAue/gSeKIHnlFBJT/A6wL9L3MD04GTwy5EUX2xioPfbrGdSfc6Rv0= X-Gm-Gg: ASbGnctxwGdaGL63sGjU3t409mn1jS5TiNVa9QRk+/m/KbwO0M3z/0fAjaPfp2dpf34 L4brxK1ebe/YLqQTXDgo2TOePCSeJihNRF2J1+VUMPDj1+zLI8Sg5Jftrn8dR30PbCl9eqfQJlI BzLYZeUtu8iOegIuAK1FnzTBaN5JfDIkemD3k1VMYum1cC4CiztfN2xt2PC6l6wLOft+UU0bVZ3 rxFdQsCWbkNt69mpD3meEFx4u7HCy2jy55IFEmZa3pZ2MWd6qm1UKuEeHk3zsBP2xjaQava5c3u 8Wn/L+Muoqvwq0AgjIRst3Z2U6jNuv0N3lyXyx9Yf05OO4g0QZ9wd/UcbztWPgoxP4YhdffNSOE qa2CsFYoByL6OuEh7kuFc0I4TuJqa6LjgUmxn X-Received: by 2002:a05:6102:4a8e:b0:5dd:b288:e780 with SMTP id ada2fe7eead31-5e1ddd7f00fmr3607730137.0.1763993295354; Mon, 24 Nov 2025 06:08:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IHSGxyZrv+zVVuTIAB14KcEtZBB1HtvXIDm+s6TM+/QPIcIeW2ctrUgygRBg5RFY9Wlh+bmKw== X-Received: by 2002:a05:6102:4a8e:b0:5dd:b288:e780 with SMTP id ada2fe7eead31-5e1ddd7f00fmr3607693137.0.1763993294895; Mon, 24 Nov 2025 06:08:14 -0800 (PST) Received: from [192.168.68.121] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-b7654d73430sm1313476066b.24.2025.11.24.06.08.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Nov 2025 06:08:14 -0800 (PST) Message-ID: <2758401b-e9b5-4f10-bb01-0a1fe4e09430@oss.qualcomm.com> Date: Mon, 24 Nov 2025 14:08:12 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] ASoC: codecs: wsa884x: remove mute_unmute_on_trigger To: Jonathan Marek , linux-arm-msm@vger.kernel.org Cc: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Krzysztof Kozlowski , Neil Armstrong , "open list:QCOM AUDIO (ASoC) DRIVERS" , open list References: <20251124064850.15419-1-jonathan@marek.ca> <20251124064850.15419-2-jonathan@marek.ca> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20251124064850.15419-2-jonathan@marek.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI0MDEyMyBTYWx0ZWRfX3MudNldws7zN k65IUhISlMMIWJZlN08AFHvcouqWAaD5Kk0/g1vV4Be8Obq8JVF4+zzPY0wLqNuwIlf5kpxbSub hiK6jOv/8D4TTqzrVjOr7PITASavZjfgEa5/p3LqWf9yVKWBE9aXVCfrske0Zhr9YtQqFSNEwhu Usef9EUdhNeTNXBdT95k7Bvlot6D6HkCrwi1d6JjwOsWp1eEkSGVlWr4nx9cBee1F6XjOvlV421 7k/3tyYf8wRQIqNcAQGcXGw61jcAyXMy8NlpyXO7i5OQx5Ogw3f5YpdvbNk5pxC+07fGHgogJTn q4cvctJ1aqA3uDzUxjcd/XH/qr/+g/dmLswBCraI0YuTEOVII+knz9hIRrTrz30g6ySWoASwh0J IQ+XeWRHHoJqYdLgzvbwDEVXPMwuyA== X-Proofpoint-GUID: iu_phZYWtNqgJZ87P7wO1A1LSLH5wT5M X-Proofpoint-ORIG-GUID: iu_phZYWtNqgJZ87P7wO1A1LSLH5wT5M X-Authority-Analysis: v=2.4 cv=GoFPO01C c=1 sm=1 tr=0 ts=692466d0 cx=c_pps a=KB4UBwrhAZV1kjiGHFQexw==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RAbU-raeAAAA:8 a=nI1KIoSTlTbwJlcfSIUA:9 a=QEXdDO2ut3YA:10 a=o1xkdb1NAhiiM49bd1HK:22 a=JiizpSU_mAIq9zsZDqn2:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-24_05,2025-11-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 impostorscore=0 bulkscore=0 adultscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511240123 On 11/24/25 6:45 AM, Jonathan Marek wrote: > trigger is atomic (non-schedulable), and soundwire register writes are not > safe to run in an atomic context. (bus is locked with a mutex, and qcom > driver's callback can also sleep if the FIFO is full). > Thanks Jonathan for the patch, We have nonatomic=1 flag set for all the Qualcomm sound cards, Did you hit any schedule while atomic bug? In-fact this change has helped suppress most of the click and pop noises on laptops, specially with wsa codecs as they accumulate static if the ports are kept open without sending any data. --srini > The important part of fixing the click/pop issue was removing the PA_EN > writes from the dapm events, AFAICT this flag doesn't help anyway. > > Fixes: 28b0b18d5346 ("ASoC: codec: wsa884x: make use of new mute_unmute_on_trigger flag") > Signed-off-by: Jonathan Marek > --- > sound/soc/codecs/wsa884x.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sound/soc/codecs/wsa884x.c b/sound/soc/codecs/wsa884x.c > index 2484d4b8e2d94..0218dfc13bc77 100644 > --- a/sound/soc/codecs/wsa884x.c > +++ b/sound/soc/codecs/wsa884x.c > @@ -1840,7 +1840,6 @@ static const struct snd_soc_dai_ops wsa884x_dai_ops = { > .hw_free = wsa884x_hw_free, > .mute_stream = wsa884x_mute_stream, > .set_stream = wsa884x_set_stream, > - .mute_unmute_on_trigger = true, > }; > > static struct snd_soc_dai_driver wsa884x_dais[] = {