From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF5A6C388F7 for ; Tue, 3 Nov 2020 15:58:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 871B822264 for ; Tue, 3 Nov 2020 15:58:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604419131; bh=f29d1wETJnFFOtXCHry4rt0aAdsEHjADIZSHXNcZEw4=; h=Subject:To:References:Cc:From:Date:In-Reply-To:List-ID:From; b=SS9ARBtB1sstkmeNkcYyUb2jOoE1394d77Lz02tD14WiLDZDuochMvABi89AKmIrx I7IXxeLtHG+4/Zpx7dke/a6BC6iKwR8u2k8Y2bq0HRf/c/pEy7FVT1bTkowTxwfyyW aGWv0R6JKbb6RvNUOR6n7dpVWTjKvOFHepWCJFkM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728090AbgKCP6u (ORCPT ); Tue, 3 Nov 2020 10:58:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:42212 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726312AbgKCP6u (ORCPT ); Tue, 3 Nov 2020 10:58:50 -0500 Received: from [192.168.0.112] (unknown [117.89.214.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8133F20870; Tue, 3 Nov 2020 15:58:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604419129; bh=f29d1wETJnFFOtXCHry4rt0aAdsEHjADIZSHXNcZEw4=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From; b=mDmilPl3uHLlORwpgRDaKaE+rOVUG8Oo71Cbiy9N42GlzeZ5WECj2DTNmmTZpsa0U 965hDAg7OT0Iz0S5+CQg473ryEPxeyaE7keYtQnncduHSjc3jhTIHHfr/IAAuo/WkT JGdC5BfRgrFb59B5i8bMdFZP9cmCi/khNzphFIyo= Subject: Re: [PATCH] erofs: derive atime instead of leaving it empty To: Gao Xiang , Chao Yu References: <20201031195102.21221-1-hsiangkao.ref@aol.com> <20201031195102.21221-1-hsiangkao@aol.com> <20201103025033.GA788000@xiangao.remote.csb> Cc: linux-erofs@lists.ozlabs.org, LKML , nl6720 , stable From: Chao Yu Message-ID: <275b73d7-9865-91c0-ecf2-bceed09a4dae@kernel.org> Date: Tue, 3 Nov 2020 23:58:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20201103025033.GA788000@xiangao.remote.csb> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Xiang, On 2020-11-3 10:50, Gao Xiang wrote: > Hi Chao, > > On Sun, Nov 01, 2020 at 03:51:02AM +0800, Gao Xiang wrote: >> From: Gao Xiang >> >> EROFS has _only one_ ondisk timestamp (ctime is currently >> documented and recorded, we might also record mtime instead >> with a new compat feature if needed) for each extended inode >> since EROFS isn't mainly for archival purposes so no need to >> keep all timestamps on disk especially for Android scenarios >> due to security concerns. Also, romfs/cramfs don't have their >> own on-disk timestamp, and squashfs only records mtime instead. >> >> Let's also derive access time from ondisk timestamp rather than >> leaving it empty, and if mtime/atime for each file are really >> needed for specific scenarios as well, we can also use xattrs >> to record them then. >> >> Reported-by: nl6720 >> [ Gao Xiang: It'd be better to backport for user-friendly concern. ] >> Fixes: 431339ba9042 ("staging: erofs: add inode operations") >> Cc: stable # 4.19+ >> Signed-off-by: Gao Xiang > > May I ask for some extra free slots to review this patch plus > [PATCH 1/4] of > https://lore.kernel.org/r/20201022145724.27284-1-hsiangkao@aol.com > > since it'd be also in linux-next for a while before sending out > to Linus. And the debugging messages may also be an annoying > thing for users. Sorry for the delay review, will check the details tomorrow. :) Thanks, > > Thanks a lot! > > Thanks, > Gao Xiang >