From: Heiko Stuebner <heiko@sntech.de>
To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-rockchip@lists.infradead.org
Subject: Re: [RFT PATCH v2 1/3] arm64: dts: rockchip: correct wifi interrupt flag in eaidk-610
Date: Mon, 10 Jul 2023 16:21:34 +0200 [thread overview]
Message-ID: <2762773.BEx9A2HvPv@phil> (raw)
In-Reply-To: <168899855919.1747213.375800621361302991.b4-ty@sntech.de>
Am Montag, 10. Juli 2023, 16:16:20 CEST schrieb Heiko Stuebner:
> On Fri, 7 Jul 2023 08:33:33 +0200, Krzysztof Kozlowski wrote:
> > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> > These are simple defines so they could be used in DTS but they will not
> > have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE.
> >
> > Correct the interrupt flags, assuming the author of the code wanted same
> > logical behavior behind the name "ACTIVE_xxx", this is:
> > ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH
> >
> > [...]
>
> Applied, thanks!
>
> [1/3] arm64: dts: rockchip: correct wifi interrupt flag in eaidk-610
> commit: 8183bb7e291b7818f49ea39687c2fafa01a46e27
> [2/3] arm64: dts: rockchip: correct wifi interrupt flag in Rock Pi 4B
> commit: cfa12c32b96fd5b12f77d880d6a1ddd2a502756e
> [3/3] arm64: dts: rockchip: correct wifi interrupt flag in Box Demo
> commit: 2d6f7e3938a7aba154c8e8afaddc8b7f1e0a1b56
we got one successful test and all the changes concern broadcom wifi
modules, I assume that this should work on all of them the same :-)
prev parent reply other threads:[~2023-07-10 14:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 6:33 [RFT PATCH v2 1/3] arm64: dts: rockchip: correct wifi interrupt flag in eaidk-610 Krzysztof Kozlowski
2023-07-07 6:33 ` [PATCH v2 2/3] arm64: dts: rockchip: correct wifi interrupt flag in Rock Pi 4B Krzysztof Kozlowski
2023-07-07 6:33 ` [RFT PATCH v2 3/3] arm64: dts: rockchip: correct wifi interrupt flag in Box Demo Krzysztof Kozlowski
2023-07-10 14:16 ` [RFT PATCH v2 1/3] arm64: dts: rockchip: correct wifi interrupt flag in eaidk-610 Heiko Stuebner
2023-07-10 14:21 ` Heiko Stuebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2762773.BEx9A2HvPv@phil \
--to=heiko@sntech.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox