From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755234AbcDFMzY (ORCPT ); Wed, 6 Apr 2016 08:55:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47347 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752382AbcDFMzV convert rfc822-to-8bit (ORCPT ); Wed, 6 Apr 2016 08:55:21 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1458316291-25705-1-git-send-email-colin.king@canonical.com> References: <1458316291-25705-1-git-send-email-colin.king@canonical.com> To: Colin King Cc: dhowells@redhat.com, Herbert Xu , "David S . Miller" , Tadeusz Struk , Peter Jones , linux-crypto@vger.kernel.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PKCS#7: fix missing break on OID_sha224 case MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2762.1459947317.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Wed, 06 Apr 2016 13:55:17 +0100 Message-ID: <2764.1459947317@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin King wrote: > From: Colin Ian King > > The OID_sha224 case is missing a break and it falls through > to the -ENOPKG error default. Since HASH_ALGO_SHA224 seems > to be supported, this looks like an unintentional missing break. > > Fixes: 07f081fb5057 ("PKCS#7: Add OIDs for sha224, sha284 and sha512 hash algos and use them") > Cc: # 4.2+ > Signed-off-by: Colin Ian King Acked-by: David Howells