Re: [PATCH v12 12/22] gpu: nova-core: mm: Add page table entry operation traits

Joel Fernandes
2026-05-02T19:19:52Z

On 5/2/2026 11:42 AM, Alexandre Courbot wrote:
> On Sun Apr 26, 2026 at 6:14 AM JST, Joel Fernandes wrote:
>> Introduce trait-based abstractions for GPU page table entries: PteOps,
>> PdeOps, and DualPdeOps, along with the MmuConfig trait that ties them
>> together with version-specific constants.
>>
>> Refactor the ver2 and ver3 page-table modules to implement these traits
>> and expose the shared entry/PDE/PTE operations uniformly.
>
> Please, no. We don't introduce code that gets refactored the very next
> commit. This patch supersedes 270 lines of diff that reviewers will have
> processed for nothing.

I really don't know what you mean by '270 lines of diff for nothing'
because this patch only adds a negative delta of 90 lines or so, before
adding yet another 300+ new lines. So it really is building on the previous
patch, which is how we do things upstream. It is iterative. My sense is you
reviewed this in a hurry and missed that fact while getting hung up on the
words 'refactor'.

Keep in mind also that the addition of PteOps set of traits refactor was
done much later in the iterations.
> Please reorder things so they land, as much as possible, in their final
> form. In this case this probably means defining the trait *before* the V2
> and V3 page table definitions, so they can implement it from the get-go.

That is a reasonable approach too, I can try to do that, but it is
misleading to say '270 lines of diff that reviewers will have processed for
nothing' which is nothing but fiction. Please look more carefully, the
patch is iterative on the series.

Thanks.