* [PATCH] usb: gadget: fix sparse warnings
@ 2015-02-05 13:02 Lad Prabhakar
2015-02-05 15:02 ` Laurent Pinchart
0 siblings, 1 reply; 6+ messages in thread
From: Lad Prabhakar @ 2015-02-05 13:02 UTC (permalink / raw)
To: Laurent Pinchart, Felipe Balbi, Greg Kroah-Hartman
Cc: linux-usb, linux-kernel, Lad, Prabhakar
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
this patch fixes following sparse warnings:
uvc_video.c:283:5: warning: symbol 'uvcg_video_pump' was not declared. Should it be static?
uvc_video.c:342:5: warning: symbol 'uvcg_video_enable' was not declared. Should it be static?
uvc_video.c:381:5: warning: symbol 'uvcg_video_init' was not declared. Should it be static?
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
drivers/usb/gadget/function/uvc_video.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/function/uvc_video.c b/drivers/usb/gadget/function/uvc_video.c
index 9cb86bc..50a5e63 100644
--- a/drivers/usb/gadget/function/uvc_video.c
+++ b/drivers/usb/gadget/function/uvc_video.c
@@ -21,6 +21,7 @@
#include "uvc.h"
#include "uvc_queue.h"
+#include "uvc_video.h"
/* --------------------------------------------------------------------------
* Video codecs
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: gadget: fix sparse warnings
2015-02-05 13:02 [PATCH] usb: gadget: fix sparse warnings Lad Prabhakar
@ 2015-02-05 15:02 ` Laurent Pinchart
2015-02-05 18:08 ` Felipe Balbi
0 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2015-02-05 15:02 UTC (permalink / raw)
To: Lad Prabhakar; +Cc: Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-kernel
Hi Prabhakar,
Thank you for the patch.
On Thursday 05 February 2015 13:02:18 Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>
> this patch fixes following sparse warnings:
>
> uvc_video.c:283:5: warning: symbol 'uvcg_video_pump' was not declared.
> Should it be static? uvc_video.c:342:5: warning: symbol 'uvcg_video_enable'
> was not declared. Should it be static? uvc_video.c:381:5: warning: symbol
> 'uvcg_video_init' was not declared. Should it be static?
>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Felipe, could you please take this in your tree ?
> ---
> drivers/usb/gadget/function/uvc_video.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/gadget/function/uvc_video.c
> b/drivers/usb/gadget/function/uvc_video.c index 9cb86bc..50a5e63 100644
> --- a/drivers/usb/gadget/function/uvc_video.c
> +++ b/drivers/usb/gadget/function/uvc_video.c
> @@ -21,6 +21,7 @@
>
> #include "uvc.h"
> #include "uvc_queue.h"
> +#include "uvc_video.h"
>
> /*
> --------------------------------------------------------------------------
> * Video codecs
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: gadget: fix sparse warnings
2015-02-05 15:02 ` Laurent Pinchart
@ 2015-02-05 18:08 ` Felipe Balbi
2015-02-08 15:46 ` Laurent Pinchart
0 siblings, 1 reply; 6+ messages in thread
From: Felipe Balbi @ 2015-02-05 18:08 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Lad Prabhakar, Felipe Balbi, Greg Kroah-Hartman, linux-usb,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 874 bytes --]
On Thu, Feb 05, 2015 at 05:02:46PM +0200, Laurent Pinchart wrote:
> Hi Prabhakar,
>
> Thank you for the patch.
>
> On Thursday 05 February 2015 13:02:18 Lad Prabhakar wrote:
> > From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
> >
> > this patch fixes following sparse warnings:
> >
> > uvc_video.c:283:5: warning: symbol 'uvcg_video_pump' was not declared.
> > Should it be static? uvc_video.c:342:5: warning: symbol 'uvcg_video_enable'
> > was not declared. Should it be static? uvc_video.c:381:5: warning: symbol
> > 'uvcg_video_init' was not declared. Should it be static?
> >
> > Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Felipe, could you please take this in your tree ?
my tree is closed for v3.20. I'll pick it up once -rc1 is out
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: gadget: fix sparse warnings
2015-02-05 18:08 ` Felipe Balbi
@ 2015-02-08 15:46 ` Laurent Pinchart
2015-02-23 15:22 ` Felipe Balbi
0 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2015-02-08 15:46 UTC (permalink / raw)
To: balbi; +Cc: Lad Prabhakar, Greg Kroah-Hartman, linux-usb, linux-kernel
Hi Felipe,
On Thursday 05 February 2015 12:08:09 Felipe Balbi wrote:
> On Thu, Feb 05, 2015 at 05:02:46PM +0200, Laurent Pinchart wrote:
> > Hi Prabhakar,
> >
> > Thank you for the patch.
> >
> > On Thursday 05 February 2015 13:02:18 Lad Prabhakar wrote:
> > > From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
> > >
> > > this patch fixes following sparse warnings:
> > >
> > > uvc_video.c:283:5: warning: symbol 'uvcg_video_pump' was not declared.
> > > Should it be static? uvc_video.c:342:5: warning: symbol
> > > 'uvcg_video_enable'
> > > was not declared. Should it be static? uvc_video.c:381:5: warning:
> > > symbol
> > > 'uvcg_video_init' was not declared. Should it be static?
> > >
> > > Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> >
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > Felipe, could you please take this in your tree ?
>
> my tree is closed for v3.20. I'll pick it up once -rc1 is out
That's good, I was targeting v3.21 too. How do you usually ensure that patches
don't get lost, do you apply them to a n+1 branch straight away (which is what
I was asking in my previous mail), rely on patchwork or some similar tool, or
expect developers to ping you again when -rc1 is out ?
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: gadget: fix sparse warnings
2015-02-08 15:46 ` Laurent Pinchart
@ 2015-02-23 15:22 ` Felipe Balbi
0 siblings, 0 replies; 6+ messages in thread
From: Felipe Balbi @ 2015-02-23 15:22 UTC (permalink / raw)
To: Laurent Pinchart
Cc: balbi, Lad Prabhakar, Greg Kroah-Hartman, linux-usb, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1483 bytes --]
On Sun, Feb 08, 2015 at 05:46:38PM +0200, Laurent Pinchart wrote:
> Hi Felipe,
>
> On Thursday 05 February 2015 12:08:09 Felipe Balbi wrote:
> > On Thu, Feb 05, 2015 at 05:02:46PM +0200, Laurent Pinchart wrote:
> > > Hi Prabhakar,
> > >
> > > Thank you for the patch.
> > >
> > > On Thursday 05 February 2015 13:02:18 Lad Prabhakar wrote:
> > > > From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
> > > >
> > > > this patch fixes following sparse warnings:
> > > >
> > > > uvc_video.c:283:5: warning: symbol 'uvcg_video_pump' was not declared.
> > > > Should it be static? uvc_video.c:342:5: warning: symbol
> > > > 'uvcg_video_enable'
> > > > was not declared. Should it be static? uvc_video.c:381:5: warning:
> > > > symbol
> > > > 'uvcg_video_init' was not declared. Should it be static?
> > > >
> > > > Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> > >
> > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > >
> > > Felipe, could you please take this in your tree ?
> >
> > my tree is closed for v3.20. I'll pick it up once -rc1 is out
>
> That's good, I was targeting v3.21 too. How do you usually ensure that patches
> don't get lost, do you apply them to a n+1 branch straight away (which is what
> I was asking in my previous mail), rely on patchwork or some similar tool, or
> expect developers to ping you again when -rc1 is out ?
I leave the email unread in another maildir
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] usb: gadget: fix sparse warnings
@ 2015-02-05 13:11 Lad Prabhakar
0 siblings, 0 replies; 6+ messages in thread
From: Lad Prabhakar @ 2015-02-05 13:11 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman, Andrzej Pietrasiewicz
Cc: linux-usb, linux-kernel, Lad, Prabhakar
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
this patch fixes following sparse warnings:
g_ffs.c:136:3: warning: symbol 'gfs_configurations' was not declared. Should it be static?
g_ffs.c:281:16: warning: Using plain integer as NULL pointer
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
Found this issue on linux-next (gcc version 4.9.2,
sparse version 0.4.5-rc1)and applies on top linux-next.
drivers/usb/gadget/legacy/g_ffs.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/legacy/g_ffs.c b/drivers/usb/gadget/legacy/g_ffs.c
index 06acfa5..b01b88e 100644
--- a/drivers/usb/gadget/legacy/g_ffs.c
+++ b/drivers/usb/gadget/legacy/g_ffs.c
@@ -133,7 +133,9 @@ struct gfs_configuration {
struct usb_configuration c;
int (*eth)(struct usb_configuration *c);
int num;
-} gfs_configurations[] = {
+};
+
+static struct gfs_configuration gfs_configurations[] = {
#ifdef CONFIG_USB_FUNCTIONFS_RNDIS
{
.eth = bind_rndis_config,
@@ -278,7 +280,7 @@ static void *functionfs_acquire_dev(struct ffs_dev *dev)
if (!try_module_get(THIS_MODULE))
return ERR_PTR(-ENOENT);
- return 0;
+ return NULL;
}
static void functionfs_release_dev(struct ffs_dev *dev)
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-02-23 15:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-05 13:02 [PATCH] usb: gadget: fix sparse warnings Lad Prabhakar
2015-02-05 15:02 ` Laurent Pinchart
2015-02-05 18:08 ` Felipe Balbi
2015-02-08 15:46 ` Laurent Pinchart
2015-02-23 15:22 ` Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2015-02-05 13:11 Lad Prabhakar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox