* [PATCH] drm: bridge: dw-hdmi: constify snd_pcm_ops structures
@ 2017-08-09 7:38 Arvind Yadav
2017-08-09 8:38 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Arvind Yadav @ 2017-08-09 7:38 UTC (permalink / raw)
To: architt, a.hajda, Laurent.pinchart, airlied, elfring
Cc: dri-devel, linux-kernel
snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
index 8f2d137..cf3f0ca 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
@@ -517,7 +517,7 @@ static snd_pcm_uframes_t dw_hdmi_pointer(struct snd_pcm_substream *substream)
return bytes_to_frames(runtime, dw->buf_offset);
}
-static struct snd_pcm_ops snd_dw_hdmi_ops = {
+static const struct snd_pcm_ops snd_dw_hdmi_ops = {
.open = dw_hdmi_open,
.close = dw_hdmi_close,
.ioctl = snd_pcm_lib_ioctl,
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: bridge: dw-hdmi: constify snd_pcm_ops structures
2017-08-09 7:38 [PATCH] drm: bridge: dw-hdmi: constify snd_pcm_ops structures Arvind Yadav
@ 2017-08-09 8:38 ` Laurent Pinchart
2017-08-09 12:36 ` Archit Taneja
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2017-08-09 8:38 UTC (permalink / raw)
To: Arvind Yadav; +Cc: architt, a.hajda, airlied, elfring, dri-devel, linux-kernel
Hi Arvind,
Thank you for the patch.
On Wednesday 09 Aug 2017 13:08:37 Arvind Yadav wrote:
> snd_pcm_ops are not supposed to change at runtime. All functions
> working with snd_pcm_ops provided by <sound/pcm.h> work with
> const snd_pcm_ops. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c index
> 8f2d137..cf3f0ca 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
> @@ -517,7 +517,7 @@ static snd_pcm_uframes_t dw_hdmi_pointer(struct
> snd_pcm_substream *substream) return bytes_to_frames(runtime,
> dw->buf_offset);
> }
>
> -static struct snd_pcm_ops snd_dw_hdmi_ops = {
> +static const struct snd_pcm_ops snd_dw_hdmi_ops = {
> .open = dw_hdmi_open,
> .close = dw_hdmi_close,
> .ioctl = snd_pcm_lib_ioctl,
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: bridge: dw-hdmi: constify snd_pcm_ops structures
2017-08-09 8:38 ` Laurent Pinchart
@ 2017-08-09 12:36 ` Archit Taneja
0 siblings, 0 replies; 3+ messages in thread
From: Archit Taneja @ 2017-08-09 12:36 UTC (permalink / raw)
To: Laurent Pinchart, Arvind Yadav
Cc: a.hajda, airlied, elfring, dri-devel, linux-kernel
On 08/09/2017 02:08 PM, Laurent Pinchart wrote:
> Hi Arvind,
>
> Thank you for the patch.
>
> On Wednesday 09 Aug 2017 13:08:37 Arvind Yadav wrote:
>> snd_pcm_ops are not supposed to change at runtime. All functions
>> working with snd_pcm_ops provided by <sound/pcm.h> work with
>> const snd_pcm_ops. So mark the non-const structs as const.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
queued to drm-misc-next
Thanks,
Archit
>
>> ---
>> drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
>> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c index
>> 8f2d137..cf3f0ca 100644
>> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
>> @@ -517,7 +517,7 @@ static snd_pcm_uframes_t dw_hdmi_pointer(struct
>> snd_pcm_substream *substream) return bytes_to_frames(runtime,
>> dw->buf_offset);
>> }
>>
>> -static struct snd_pcm_ops snd_dw_hdmi_ops = {
>> +static const struct snd_pcm_ops snd_dw_hdmi_ops = {
>> .open = dw_hdmi_open,
>> .close = dw_hdmi_close,
>> .ioctl = snd_pcm_lib_ioctl,
>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-09 12:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-09 7:38 [PATCH] drm: bridge: dw-hdmi: constify snd_pcm_ops structures Arvind Yadav
2017-08-09 8:38 ` Laurent Pinchart
2017-08-09 12:36 ` Archit Taneja
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).