From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dvalin.narfation.org (dvalin.narfation.org [213.160.73.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E7A82AEE1; Wed, 9 Apr 2025 08:10:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.160.73.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744186249; cv=none; b=uyQENBRsIPbpQs4nv5MVrqF2q8b67SLAN0o6aUV/zq29LMvAfdh9d+GCZTqHzZjgSDyrIfa4BGlqHeTF+ifihfdtATvEO/S5OXhbjuLW7lh6A45TMFjQlZhpspSOC6Gdm++8pH7udfLfbNwRR8nG/BPDehWzaB8alLtbKCRCWMQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744186249; c=relaxed/simple; bh=1xxkUhMgV8TI7tAoKd55ZN5KNUdwCInEkdqC613bWjA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hPXRoD8A+udxODdzbft/83pXDIJBlJxrJkAqNeLBS9d17C8tJbfuzd8WuR9l2alPwQJEVxdcLyhCBLrGfmAGELv/+SOjwn2ZciVgbhWj6E4ue1O9n4gzVdq+XPYrhxcXyyOZB9ko0T+OKUbz08lG3PuAm/6CqZ8QL6JcXt90tMI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=narfation.org; spf=pass smtp.mailfrom=narfation.org; dkim=pass (1024-bit key) header.d=narfation.org header.i=@narfation.org header.b=f6+8cpJ9; arc=none smtp.client-ip=213.160.73.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=narfation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=narfation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=narfation.org header.i=@narfation.org header.b="f6+8cpJ9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=narfation.org; s=20121; t=1744186244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PflrDb8OhffdMQCbjwbS7Ify9Hy35vaMmsHmfVvb/DY=; b=f6+8cpJ9j2V2kU/c+O8lQqYmKofdK+9NIE1BBIG8bqrs/ssl7TTk9BxlHu8/yerX7yY4KG HIWQuPy5OqLNSV0mG8kXXN/iPh7ezl2Km2H8rCQRTSVTOl6q3o5U1wtRUF0T+AWddJhXID H+FeiNN7WUnE0EGMFYs6PwR2//NFf0o= From: Sven Eckelmann To: Marek Lindner , Simon Wunderlich , Antonio Quartulli , Matthias Schiffer Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , b.a.t.m.a.n@lists.open-mesh.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Schiffer Subject: Re: [PATCH net-next] net: batman-adv: constify and move broadcast addr definition Date: Wed, 09 Apr 2025 10:10:39 +0200 Message-ID: <2789676.Lt9SDvczpP@ripper> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4558621.ejJDZkT8p0"; micalg="pgp-sha512"; protocol="application/pgp-signature" --nextPart4558621.ejJDZkT8p0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Sven Eckelmann Date: Wed, 09 Apr 2025 10:10:39 +0200 Message-ID: <2789676.Lt9SDvczpP@ripper> MIME-Version: 1.0 On Tuesday, 8 April 2025 17:53:36 CEST Matthias Schiffer wrote: > + const u8 broadcast_addr[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff}; Should most likely be "static const u8 ..." (checkpatch STATIC_CONST_CHAR_ARRAY) Kind regards, Sven --nextPart4558621.ejJDZkT8p0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQS81G/PswftH/OW8cVND3cr0xT1ywUCZ/YrfwAKCRBND3cr0xT1 y1fnAQCy1/kEIFf15jWwkR3S+Qdew6LxzAvY8o6jP+JPRDwUYQEAue+zH2A71OaA UYqB9V4j1Sg7iuRxg9Ezzcdl47cB4A0= =b7CK -----END PGP SIGNATURE----- --nextPart4558621.ejJDZkT8p0--