From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751944AbaCXXOk (ORCPT ); Mon, 24 Mar 2014 19:14:40 -0400 Received: from gloria.sntech.de ([95.129.55.99]:40941 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750816AbaCXXOj convert rfc822-to-8bit (ORCPT ); Mon, 24 Mar 2014 19:14:39 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Beniamino Galvani Cc: Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: rockchip: fix offset of mux registers for rk3188 Date: Tue, 25 Mar 2014 00:14:42 +0100 Message-ID: <2790002.5U2DHYmUbK@diego> User-Agent: KMail/4.11.5 (Linux/3.13-1-amd64; KDE/4.11.3; x86_64; ; ) In-Reply-To: <1395700561-3793-1-git-send-email-b.galvani@gmail.com> References: <1395700561-3793-1-git-send-email-b.galvani@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, 24. März 2014, 23:36:01 schrieb Beniamino Galvani: > The correct value of .mux_offset for rk3188 seems to be 0x60 > instead of 0x68. Executive summary: the offset-change itself is correct, therefore Reviewed-by: Heiko Stuebner That is what one gets when the only source is a vendor tree. I've looked it up again, and it seems you're right with the offset, but there seems to be more to it ;-) GPIO0 only has the second two IOMUX registers: - GRF_GPIO0C_IOMUX at 0x68 - GRF_GPIO0D_IOMUX at 0x6c which I guess is where my mistake comes from. It looks like there does no iomux register exist at all for the first 16 pins. In any case, the current number is wrong, and the 0x60 offset is the correct one, but I guess we need to determine what the affected pins do - do they always have a gpio mux or such? Thanks for catching the mistake. Heiko > Signed-off-by: Beniamino Galvani > --- > drivers/pinctrl/pinctrl-rockchip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-rockchip.c > b/drivers/pinctrl/pinctrl-rockchip.c index 46dddc1..23e8812 100644 > --- a/drivers/pinctrl/pinctrl-rockchip.c > +++ b/drivers/pinctrl/pinctrl-rockchip.c > @@ -1534,7 +1534,7 @@ static struct rockchip_pin_ctrl rk3188_pin_ctrl = { > .nr_banks = ARRAY_SIZE(rk3188_pin_banks), > .label = "RK3188-GPIO", > .type = RK3188, > - .mux_offset = 0x68, > + .mux_offset = 0x60, > .pull_calc_reg = rk3188_calc_pull_reg_and_bit, > };