From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751994AbdKIDdi (ORCPT ); Wed, 8 Nov 2017 22:33:38 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:50184 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495AbdKIDdg (ORCPT ); Wed, 8 Nov 2017 22:33:36 -0500 From: Laurent Pinchart To: "H. Nikolaus Schaller" Cc: Thierry Reding , David Airlie , Rob Herring , Mark Rutland , =?ISO-8859-1?Q?Beno=EEt?= Cousson , Tony Lindgren , Russell King , Tomi Valkeinen , Bartlomiej Zolnierkiewicz , Julia Lawall , Sean Paul , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com Subject: Re: [PATCH 1/4] omapdrm: fix compatible string for td028ttec1 Date: Thu, 09 Nov 2017 05:33:40 +0200 Message-ID: <2790033.EQlQQc1BPI@avalon> Organization: Ideas on Board Oy In-Reply-To: <8678120467a1d0e67d4d882b3f01d58867586653.1510175371.git.hns@goldelico.com> References: <8678120467a1d0e67d4d882b3f01d58867586653.1510175371.git.hns@goldelico.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nikolaus, Thank you for the patch. On Wednesday, 8 November 2017 23:09:29 EET H. Nikolaus Schaller wrote: > The vendor name was "toppoly" but other panels and the vendor list > have defined it as "tpo". So let's fix it in driver and bindings. > > Signed-off-by: H. Nikolaus Schaller > --- > .../display/panel/{toppoly,td028ttec1.txt => tpo,td028ttec1.txt} | 4 ++-- > drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c | 4 ++-- > drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > rename > Documentation/devicetree/bindings/display/panel/{toppoly,td028ttec1.txt => > tpo,td028ttec1.txt} (84%) > > diff --git > a/Documentation/devicetree/bindings/display/panel/toppoly,td028ttec1.txt > b/Documentation/devicetree/bindings/display/panel/tpo,td028ttec1.txt > similarity index 84% > rename from > Documentation/devicetree/bindings/display/panel/toppoly,td028ttec1.txt > rename to > Documentation/devicetree/bindings/display/panel/tpo,td028ttec1.txt index > 7175dc3740ac..ed34253d9fb1 100644 > --- a/Documentation/devicetree/bindings/display/panel/toppoly,td028ttec1.txt > +++ b/Documentation/devicetree/bindings/display/panel/tpo,td028ttec1.txt @@ > -2,7 +2,7 @@ Toppoly TD028TTEC1 Panel > ======================== > > Required properties: > -- compatible: "toppoly,td028ttec1" > +- compatible: "tpo,td028ttec1" > > Optional properties: > - label: a symbolic name for the panel > @@ -14,7 +14,7 @@ Example > ------- > > lcd-panel: td028ttec1@0 { > - compatible = "toppoly,td028ttec1"; > + compatible = "tpo,td028ttec1"; > reg = <0>; > spi-max-frequency = <100000>; > spi-cpol; > diff --git a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c > b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c index > 0a38a0e8c925..2dab491478c2 100644 > --- a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c > +++ b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c > @@ -452,7 +452,7 @@ static int td028ttec1_panel_remove(struct spi_device > *spi) } > > static const struct of_device_id td028ttec1_of_match[] = { > - { .compatible = "omapdss,toppoly,td028ttec1", }, > + { .compatible = "omapdss,tpo,td028ttec1", }, Doesn't this break backward compatibility with existing DT ? > {}, > }; > > @@ -471,7 +471,7 @@ static struct spi_driver td028ttec1_spi_driver = { > > module_spi_driver(td028ttec1_spi_driver); > > -MODULE_ALIAS("spi:toppoly,td028ttec1"); > +MODULE_ALIAS("spi:tpo,td028ttec1"); > MODULE_AUTHOR("H. Nikolaus Schaller "); > MODULE_DESCRIPTION("Toppoly TD028TTEC1 panel driver"); > MODULE_LICENSE("GPL"); > diff --git > a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c > b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c index > 57e9e146ff74..39e1754746d2 100644 > --- a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c > +++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c > @@ -455,7 +455,7 @@ static int td028ttec1_panel_remove(struct spi_device > *spi) } > > static const struct of_device_id td028ttec1_of_match[] = { > - { .compatible = "omapdss,toppoly,td028ttec1", }, > + { .compatible = "omapdss,tpo,td028ttec1", }, > {}, > }; > > @@ -474,7 +474,7 @@ static struct spi_driver td028ttec1_spi_driver = { > > module_spi_driver(td028ttec1_spi_driver); > > -MODULE_ALIAS("spi:toppoly,td028ttec1"); > +MODULE_ALIAS("spi:tpo,td028ttec1"); > MODULE_AUTHOR("H. Nikolaus Schaller "); > MODULE_DESCRIPTION("Toppoly TD028TTEC1 panel driver"); > MODULE_LICENSE("GPL"); -- Regards, Laurent Pinchart