From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758310AbcIMPIC (ORCPT ); Tue, 13 Sep 2016 11:08:02 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:60614 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751745AbcIMPIA (ORCPT ); Tue, 13 Sep 2016 11:08:00 -0400 From: Arnd Bergmann To: Deepa Dinamani Cc: Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, y2038@lists.linaro.org Subject: Re: [PATCH 1/4] uinput: Add ioctl for using monotonic/ boot times Date: Tue, 13 Sep 2016 17:07:56 +0200 Message-ID: <2791498.1bf6TGcxHc@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1473775805-2242-2-git-send-email-deepa.kernel@gmail.com> References: <1473775805-2242-1-git-send-email-deepa.kernel@gmail.com> <1473775805-2242-2-git-send-email-deepa.kernel@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:tQHWW6QgBYy99A4tfqmHTWCVIZImDR6BmDJ1QlTZs3uOmGwKXzV KcXtsDmmu8NyZSlKt7fxyryevFgTOzQcJyWWUhqBY1o9Gn/wll6motxLVpYY7EzsJiO9gCd WIHEvqKAuteNrcgVM88LNLpMQI4n19tk8eh9NmMi2qZi9UvMLE7ytdQyAmJCFAv8woJGxiX QZ94MdIq096PFagU1qD+A== X-UI-Out-Filterresults: notjunk:1;V01:K0:SRlbCP55EYo=:IuGGEPb9W7wdc0CEld7aBC 4dJWpmkzw6Poe6AKm+c5O5msVFoh9Fkvv2QXR6AACiOXdQlscj7jFGH92C97b1bfteM07/khv 4KVubBWSW78eDZ/HMhjEwjBxaY5Zw5PgXuFA1JN/1z3Yz5uIoAKJ51CSqTJsbHog4DcxM8/JU l+oFeVjnCC7ByYR2SbWowyMc4e6ZFMkwBv2VI3huJDVvnurb20Vhj/B+/zERIbs1wlsEtkql+ vIAASXaE5ucB9P8hKZ2buorjF5Hww/nX7f0xmpj47bKy/HAZzjIh68t+AlEMPoEM3Q3nlPvh/ 3ulTThN7HkCqkprYvjsYYwK9/RhSwLiwiMceGaG6QUanGVbzfn9Yd+PCEauijfm0auvcHNEI1 0FKZjV1GXp9CBFFEp0NrPaN6hGE624C3DfykRLyZWfGaHjthyPttRBwy5pN8jCM6uxZtHLIeU XN85YSlSQJMdP7deMEWM2wAKMDI8vBDcAGBD91D8zjR3Wssen0hYdclShkxqlC/d8duABrXAl RuLJ1/gVU6JSDqogVdoVHRwV8BWzNFGy21lTTZQgc5U9tz31uqDlsAqxisrBUIjz6vUBEdu0U r0L7kbJ2eR9sKAW8vD/WXI18+H9wNA6WJ9sCWOFNjxwiC9zDVf8PlkbrANMd+gtq187/iaDT3 RNtki6T0K9flOST8EdSxmF1oq1q14dC5RhNtSiT7seANjesYS99r3Plci/7oB8JmZSweHivmr t6W7kmlqGG0bj39V Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, September 13, 2016 7:10:02 AM CEST Deepa Dinamani wrote: > --- a/drivers/input/misc/uinput.c > +++ b/drivers/input/misc/uinput.c > @@ -46,11 +46,28 @@ static int uinput_dev_event(struct input_dev *dev, > unsigned int type, unsigned int code, int value) > { > struct uinput_device *udev = input_get_drvdata(dev); > + struct timespec64 ts; > + ktime_t kt; > > udev->buff[udev->head].type = type; > udev->buff[udev->head].code = code; > udev->buff[udev->head].value = value; > - do_gettimeofday(&udev->buff[udev->head].time); > + > + kt = ktime_get(); > + switch (udev->clk_type) { > + case CLOCK_REALTIME: > + ts = ktime_to_timespec64(ktime_mono_to_real(kt)); > + break; > + case CLOCK_MONOTONIC: > + ts = ktime_to_timespec64(kt); > + break; > + case CLOCK_BOOTTIME: > + ts = ktime_to_timespec64(ktime_mono_to_any(kt, TK_OFFS_BOOT)); > + break; > + } > + > + udev->buff[udev->head].time.tv_sec = ts.tv_sec; > + udev->buff[udev->head].time.tv_usec = ts.tv_nsec / NSEC_PER_USEC; > This is a bit inefficient. I think it's better to use ktime_get_real_ts64(), ktime_get_ts64() and get_monotonic_boottime64(). I see that we do the same thing in evdev_events(), so maybe that isn't overly critical though. Or we might want to change both. The last one of these also uses the slow ktime_to_timespec64(), but that is something we can improve later in the common code. Arnd