Re: [PATCH 00/10] Add device tree for ArmSoM Sige 5 board

Rob Herring (Arm)
2024-08-05T15:00:15Z

On Fri, 02 Aug 2024 17:45:27 -0400, Detlev Casanova wrote:
> Add the rk3576-armsom-sige5 device tree as well as its rk3576.dtsi base
> and pinctrl information in rk3576-pinctrl.dtsi.
>
> The other commits add DT bindings documentation for the devices that
> already work with the current corresponding drivers.
>
> The other bindings and driver implementations are in other patch sets:
> - PMIC: https://lore.kernel.org/lkml/20240802134736.283851-1-detlev.casanova@collabora.com/
> - CRU: https://lore.kernel.org/lkml/20240802214053.433493-1-detlev.casanova@collabora.com/
> - PINCTRL: https://lore.kernel.org/lkml/20240802145458.291890-1-detlev.casanova@collabora.com/
> - PM DOMAIN: https://lore.kernel.org/lkml/20240802151647.294307-1-detlev.casanova@collabora.com/
> - DW-MMC: https://lore.kernel.org/lkml/20240802153609.296197-1-detlev.casanova@collabora.com/
> - GMAC: https://lore.kernel.org/lkml/20240802173918.301668-1-detlev.casanova@collabora.com/
>
> Detlev Casanova (10):
> dt-bindings: arm: rockchip: Add ArmSoM Sige 5
> dt-bindings: arm: rockchip: Add rk576 compatible string to pmu.yaml
> dt-bindings: i2c: i2c-rk3x: Add rk3576 compatible
> dt-bindings: iio: adc: Add rockchip,rk3576-saradc string
> dt-bindings: mfd: syscon: Add rk3576 QoS register compatible
> dt-bindings: serial: snps-dw-apb-uart: Add Rockchip RK3576
> dt-bindings: soc: rockchip: Add rk3576 syscon compatibles
> dt-bindings: timer: rockchip: Add rk3576 compatible
> arm64: dts: rockchip: Add rk3576 SoC base DT
> arm64: dts: rockchip: Add rk3576-armsom-sige5 board
>
> .../devicetree/bindings/arm/rockchip.yaml | 5 +
> .../devicetree/bindings/arm/rockchip/pmu.yaml | 2 +
> .../devicetree/bindings/i2c/i2c-rk3x.yaml | 1 +
> .../bindings/iio/adc/rockchip-saradc.yaml | 3 +
> .../devicetree/bindings/mfd/syscon.yaml | 2 +
> .../bindings/serial/snps-dw-apb-uart.yaml | 1 +
> .../devicetree/bindings/soc/rockchip/grf.yaml | 16 +
> .../bindings/timer/rockchip,rk-timer.yaml | 1 +
> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> .../boot/dts/rockchip/rk3576-armsom-sige5.dts | 613 ++
> .../boot/dts/rockchip/rk3576-pinctrl.dtsi | 5775 +++++++++++++++++
> arch/arm64/boot/dts/rockchip/rk3576.dtsi | 1635 +++++
> 12 files changed, 8055 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3576-pinctrl.dtsi
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3576.dtsi
>
> --
> 2.46.0
>
>
>

My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

pip3 install dtschema --upgrade

New warnings running 'make CHECK_DTBS=y rockchip/rk3576-armsom-sige5.dtb' for 20240802214612.434179-1-detlev.casanova@collabora.com:

In file included from arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts:14:
arch/arm64/boot/dts/rockchip/rk3576.dtsi:6:10: fatal error: dt-bindings/clock/rockchip,rk3576-cru.h: No such file or directory
6 | #include <dt-bindings/clock/rockchip,rk3576-cru.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[3]: *** [scripts/Makefile.lib:434: arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb] Error 1
make[2]: *** [scripts/Makefile.build:485: arch/arm64/boot/dts/rockchip] Error 2
make[2]: Target 'arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb' not remade because of errors.
make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1389: rockchip/rk3576-armsom-sige5.dtb] Error 2
make: *** [Makefile:224: __sub-make] Error 2
make: Target 'rockchip/rk3576-armsom-sige5.dtb' not remade because of errors.