From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755961AbbEUR6b (ORCPT ); Thu, 21 May 2015 13:58:31 -0400 Received: from gloria.sntech.de ([95.129.55.99]:49156 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754083AbbEUR62 (ORCPT ); Thu, 21 May 2015 13:58:28 -0400 From: Heiko Stuebner To: Doug Anderson Cc: "Huang, Tao" , Russell King , "linux-kernel@vger.kernel.org" , "open list:ARM/Rockchip SoC..." , Chris Zhong , "linux-arm-kernel@lists.infradead.org" , Tony Xie Subject: Re: [PATCH] ARM: rockchip: restore dapswjdp after suspend Date: Thu, 21 May 2015 19:59:13 +0200 Message-ID: <2799695.KoAD3Q19Xm@phil> User-Agent: KMail/4.14.1 (Linux/3.19.0+; KDE/4.14.2; x86_64; ; ) In-Reply-To: References: <1432154048-19126-1-git-send-email-dianders@chromium.org> <555D3CB7.2000002@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Doug, Am Donnerstag, 21. Mai 2015, 08:40:55 schrieb Doug Anderson: > On Wed, May 20, 2015 at 7:02 PM, Huang, Tao wrote: > >> It turns out that's not a safe assumption. In some cases (pending > >> interrupts) it's possible that the WFI might act as a no-op and the > >> MaskROM will never run. > > Anyway, restore the value is okay, which make the code more symmetrically > > OK. Heiko: applying this won't hurt, but it will only be useful if we > find a way to return from the WFI successfully... As it looks sane but doesn't fix an immediate problem I have applied this to my soc-branch for 4.2 . Thanks Heiko