From: David Laight <David.Laight@ACULAB.COM>
To: "'Valdis Klētnieks'" <valdis.kletnieks@vt.edu>,
"Kees Cook" <keescook@chromium.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"linux-hardening@vger.kernel.org"
<linux-hardening@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH RESEND] gcc-plugins: avoid errors with -std=gnu++11 on old gcc
Date: Thu, 18 Mar 2021 11:41:29 +0000 [thread overview]
Message-ID: <279b22592f1e43a48beeecd34e50b385@AcuMS.aculab.com> (raw)
In-Reply-To: <282490.1616047333@turing-police>
From: Valdis Kletnieks
> Sent: 18 March 2021 06:02
>
> On Wed, 17 Mar 2021 22:52:56 -0700, Kees Cook said:
> > On Mon, Mar 08, 2021 at 03:40:21AM -0500, Valdis KlD\x13tnieks wrote:
> > > It turns out that older gcc (4.9 and 5.4) have gnu++11 support, but
> > > due to a gcc bug fixed in gcc6, throw errors during the build.
> > > The relevant gcc bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69959
> > >
> > > Version the option based on what gcc we're using.
> >
> > Is there a better way to detect this than with version checking?
>
> Not really. gcc 11 needs --std=gnu++11 to build it. And although
> gcc4 and gcc5 *claim* to support it, there's a known bug, so we *can't*
> feed gnu++11 to them. We can check versions..
That gcc bug just implies you need a space after "xxx".
That is easily fixable in the sources.
Is there another problem?
(Apart from the standards committee breaking everything again.)
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2021-03-18 11:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 8:40 [PATCH RESEND] gcc-plugins: avoid errors with -std=gnu++11 on old gcc Valdis Klētnieks
2021-03-18 5:52 ` Kees Cook
2021-03-18 6:02 ` Valdis Klētnieks
2021-03-18 6:26 ` Miguel Ojeda
2021-03-18 9:07 ` Masahiro Yamada
2021-03-18 11:47 ` Valdis Klētnieks
2021-03-18 11:41 ` David Laight [this message]
2021-03-18 11:55 ` Valdis Klētnieks
2021-03-18 13:38 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=279b22592f1e43a48beeecd34e50b385@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=geert@linux-m68k.org \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox