Re: [RFC PATCH 05/12] fs/proc/task_mmu: refactor pagemap_pmd_range()

David Hildenbrand
2025-10-27T16:32:01Z

>
> I don't love the union.
>
> How would we determine what type it is, we'd have to have some
> generic_leaf_entry_t type or something to contain the swap type field and then
> cast and... is it worth it?
>
> Intent of non-present was to refer to not-swap swapentry. It's already a
> convention that exists, e.g. is_pmd_non_present_folio_entry().

Just noting that this was a recent addition (still not upstream) that
essentially says "there is a folio here, but it's not in an ordinary
present page table entry.

So we could change that to something better.

--
Cheers

David / dhildenb