Re: [PATCH V2 2/7] i2c: sprd: Add I2C driver to use 'reset framework' function

Krzysztof Kozlowski
2023-11-03T11:59:27Z

On 23/10/2023 10:11, Huangzheng Lai wrote:
> Add the 'reset framework' function for I2C drivers, which
> resets the I2C controller when a timeout exception occurs.
>
> Signed-off-by: Huangzheng Lai <Huangzheng.Lai@unisoc.com>
> ---
> drivers/i2c/busses/i2c-sprd.c | 19 +++++++++++++++++--

> return -ETIMEDOUT;
> -
> + }
> return i2c_dev->err;
> }
>
> @@ -544,6 +554,11 @@ static int sprd_i2c_probe(struct platform_device *pdev)
> return ret;
>
> platform_set_drvdata(pdev, i2c_dev);
> + i2c_dev->rst = devm_reset_control_get(i2c_dev->dev, "i2c_rst");

NAK

This is not documented in the bindings. You cannot sneak properties
without their documentation. Also, you cannot sneak new properties to
bindings conversion patches!

Send proper patchset following submission rules, so first documentation,
then driver implementing new feature. One patchset.

Best regards,
Krzysztof