From: Lu Baolu <baolu.lu@linux.intel.com>
To: Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>, Jason Gunthorpe <jgg@nvidia.com>,
Christoph Hellwig <hch@infradead.org>,
Ben Skeggs <bskeggs@redhat.com>,
Kevin Tian <kevin.tian@intel.com>,
Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>
Cc: baolu.lu@linux.intel.com,
Alex Williamson <alex.williamson@redhat.com>,
Eric Auger <eric.auger@redhat.com>, Liu Yi L <yi.l.liu@intel.com>,
Jacob jun Pan <jacob.jun.pan@intel.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 08/10] iommu: Remove unused argument in is_attach_deferred
Date: Thu, 10 Feb 2022 08:51:08 +0800 [thread overview]
Message-ID: <27fbcb02-4f13-3377-eadd-e689ce063348@linux.intel.com> (raw)
In-Reply-To: <290a89f0-8318-6130-468c-6412add62cfb@arm.com>
On 2/9/22 9:52 PM, Robin Murphy wrote:
>> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
>> index 2b5f4e57a8bb..80f1294be634 100644
>> --- a/drivers/iommu/intel/iommu.c
>> +++ b/drivers/iommu/intel/iommu.c
>> @@ -5052,8 +5052,7 @@ intel_iommu_dev_disable_feat(struct device *dev,
>> enum iommu_dev_features feat)
>> }
>> }
>> -static bool intel_iommu_is_attach_deferred(struct iommu_domain *domain,
>> - struct device *dev)
>> +static bool intel_iommu_is_attach_deferred(struct device *dev)
>> {
>> return attach_deferred(dev);
>
> Seems like there's no need to wrap this now?
Yes. It's pointless.
Best regards,
baolu
next prev parent reply other threads:[~2022-02-10 1:23 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 1:25 [PATCH v2 00/10] iommu cleanup and refactoring Lu Baolu
2022-02-08 1:25 ` [PATCH v2 01/10] iommu/vt-d: Remove guest pasid related callbacks Lu Baolu
2022-02-09 13:29 ` Jason Gunthorpe
2022-02-08 1:25 ` [PATCH v2 02/10] iommu: Remove guest pasid related interfaces and definitions Lu Baolu
2022-02-09 13:29 ` Jason Gunthorpe
2022-02-10 0:44 ` Lu Baolu
2022-02-08 1:25 ` [PATCH v2 03/10] iommu/vt-d: Remove aux-domain related callbacks Lu Baolu
2022-02-09 13:30 ` Jason Gunthorpe
2022-02-08 1:25 ` [PATCH v2 04/10] iommu: Remove aux-domain related interfaces and iommu_ops Lu Baolu
2022-02-09 13:30 ` Jason Gunthorpe
2022-02-08 1:25 ` [PATCH v2 05/10] iommu: Remove apply_resv_region Lu Baolu
2022-02-09 6:36 ` Christoph Hellwig
2022-02-09 13:31 ` Jason Gunthorpe
2022-02-08 1:25 ` [PATCH v2 06/10] drm/nouveau/device: Get right pgsize_bitmap of iommu_domain Lu Baolu
2022-02-09 13:31 ` Jason Gunthorpe
2022-02-10 0:48 ` Lu Baolu
2022-02-08 1:25 ` [PATCH v2 07/10] iommu: Use right way to retrieve iommu_ops Lu Baolu
2022-02-09 6:40 ` Christoph Hellwig
2022-02-09 13:33 ` Jason Gunthorpe
2022-02-08 1:25 ` [PATCH v2 08/10] iommu: Remove unused argument in is_attach_deferred Lu Baolu
2022-02-09 6:41 ` Christoph Hellwig
2022-02-09 13:34 ` Jason Gunthorpe
2022-02-09 13:52 ` Robin Murphy
2022-02-10 0:51 ` Lu Baolu [this message]
2022-02-14 0:50 ` Lu Baolu
2022-02-08 1:25 ` [PATCH v2 09/10] iommu: Use dev_iommu_ops() helper Lu Baolu
2022-02-09 6:44 ` Christoph Hellwig
2022-02-09 13:41 ` Jason Gunthorpe
2022-02-10 1:10 ` Lu Baolu
2022-02-08 1:25 ` [PATCH v2 10/10] iommu: Split struct iommu_ops Lu Baolu
2022-02-09 6:46 ` Christoph Hellwig
2022-02-09 13:43 ` Jason Gunthorpe
2022-02-14 2:00 ` [PATCH v2 00/10] iommu cleanup and refactoring Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27fbcb02-4f13-3377-eadd-e689ce063348@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=airlied@linux.ie \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=eric.auger@redhat.com \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=jgg@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox