From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754866AbcBPLil (ORCPT ); Tue, 16 Feb 2016 06:38:41 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:57028 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753160AbcBPLij (ORCPT ); Tue, 16 Feb 2016 06:38:39 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Stefano Stabellini , Andrew Jones , xen-devel@lists.xensource.com, Konrad Rzeszutek Wilk , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tomi Valkeinen , David Vrabel , boris.ostrovsky@oracle.com, Jean-Christophe Plagniol-Villard Subject: Re: [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select Date: Tue, 16 Feb 2016 12:35:26 +0100 Message-ID: <2801550.oZPkqjv8nW@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1455278707-2008263-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:EgVlsnu45UrWQoF0FMKXurAyxV8Yhn2c7ygA1FUCHsaYjSD+u6F P5sMqN+C+coFVo9X4/LrfuoPUY1TWiS5PqRUp8qI/XEPmjqU6AJpl1wQxLRZ+B4fYjme5Me jIMDbTns9sX54KVoTJaAxVaiLZ8xn0Pnydqaz57IBddKr/MKglG0/PbCuIwTxNC236PtriI ETUxmOoVAhwVia7kKFv3g== X-UI-Out-Filterresults: notjunk:1;V01:K0:8lreZFxtdHg=:JSS+vL2XRYsw9rCNU775Cq nRoq2Ifph9fy6XeIRLLgMLu9y8wo28aQoijqB4TGVRTUDxpGSE5HWyRy2rWwEgLAZXRdfE0fb OTuNG2eBlElGCC02sepbflHbJfqkcV8p636TYid1F9c4ZpOmMevNAxf4/pekXikCWcXWTVzFx 0sxjP277zmHuTaxYIzErypBnce1CX40hW1RzCjrsSlUUO7cgznnkExQU3LtuzitvoIP1kIaIb epmGwp+Asiq07BVfbC9Jg9+sGWGqUs6KTRa7E7GrTILpuPL8TPHnwW6TgrxcyMkj4wNeJ9S15 Mtu3hHb3z7LAmOySruiWbukvnD6haIAi/utgYUIYiEZ8R2znUqH9ZqzqfTSZAXfmpzhsMT9t7 +qGiy8HIS0Zu+VdlbsJNXaBbN2A5Usr8C25iMKMIa2jAlMcS/NJnAW03mnc3FfKWGkD9xt+dg DgsuzpxHi72sLilznLmMx2fflsNw4CA/hkA0dEsSU23mVXci/c7RDCd8lxXRif3hirwg5Ihs8 0tfVB2qdS7MRaG5cTiiBWvWwc4zNV5e+C1cU03vqmUCAIig9leei7j15eIMYkQLihqtvqTIKF Zo/5wn6JnIXMY9s3hxQvANtH4aG2rtTgh5JnLolwxYM6n+cxfKrtQaJ9Fmpk+AfM0JMZuNbg1 8bQdeqXXqTSDe+w0y1mzn/LKgHbsUd7RUkTWwBwuXZcQhb3/9DhqkSbdq2CoHxp9G4Cd851JW 9I/er5Q/IVAjvdmQ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 15 February 2016 16:51:08 Stefano Stabellini wrote: > > > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > > index 8ea45a5cd806..fd3d6fd290a9 100644 > > --- a/drivers/video/fbdev/Kconfig > > +++ b/drivers/video/fbdev/Kconfig > > @@ -2241,6 +2241,7 @@ config FB_VIRTUAL > > config XEN_FBDEV_FRONTEND > > tristate "Xen virtual frame buffer support" > > depends on FB && XEN > > + depends on INPUT || !INPUT_MISC > > select FB_SYS_FILLRECT > > select FB_SYS_COPYAREA > > select FB_SYS_IMAGEBLIT > > This looks very hackish. Couldn't we just do the following? > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > index 8ea45a5..3c15f6d 100644 > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -2246,7 +2246,7 @@ config XEN_FBDEV_FRONTEND > select FB_SYS_IMAGEBLIT > select FB_SYS_FOPS > select FB_DEFERRED_IO > - select INPUT_XEN_KBDDEV_FRONTEND if INPUT_MISC > + select INPUT_XEN_KBDDEV_FRONTEND if (INPUT && INPUT_MISC) > select XEN_XENBUS_FRONTEND > default y > help > No, that doesn't solve the problem: If XEN_FBDEV_FRONTEND=y, INPUT=m and INPUT_MISC=y, we would still get INPUT_XEN_KBDDEV_FRONTEND=y, which cannot work because of INPUT=m. INPUT_MISC already depends on INPUT, so your change has no effect at all. Arnd