From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933546AbbKSAZU (ORCPT ); Wed, 18 Nov 2015 19:25:20 -0500 Received: from mail-pa0-f48.google.com ([209.85.220.48]:36188 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751150AbbKSAZS (ORCPT ); Wed, 18 Nov 2015 19:25:18 -0500 From: Joshua Clayton To: Alexandre Belloni , linux-kernel@vger.kernel.org Cc: Alessandro Zummo , rtc-linux@googlegroups.com Subject: Re: [PATCH 0/9] rtc-2123: access the clock offset feature Date: Wed, 18 Nov 2015 16:25:14 -0800 Message-ID: <2802614.ZvDTOLQF6p@jclayton-pc> User-Agent: KMail/5.0.2 (Linux/4.2.0-18-generic; KDE/5.15.0; x86_64; ; ) In-Reply-To: <20151117162530.GC14677@piout.net> References: <2107368.j5bIbb5cBF@jclayton-pc> <20151117162530.GC14677@piout.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, November 17, 2015 05:25:30 PM Alexandre Belloni wrote: > On 17/11/2015 at 07:30:48 -0800, Joshua Clayton wrote : > > On Wednesday, November 04, 2015 07:36:31 AM Joshua Clayton wrote: > > Any comments on this series? > > I realize now that I submitted it during the merge window, so it may have been overlooked. > > > > I will have a few comments but I didn't review everything thoroughly > yet. As you mentioned, you submitted during the merge window so this was > not going to be in 4.4 anyway. > > Thanks! I can relax since I know it is on your radar. I have responded my self to a couple of fat fingers in the commit messages. I am also in the process of testing the actual effects of the feature. One thing I'm not sure I have adequately described (and didn't really understand until I started testing) is that a positive value in the adjust register increases the average value of a second, so it makes the clock slower, while a negative adjustment makes it faster. This was counterintuitive to me. Not having deeply examined other rtc's with similar capabilities, I can't say whether this is the norm. -- ~Joshua Clayton