public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Valdis.Kletnieks@vt.edu
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Zhu Yi <yi.zhu@intel.com>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	ipw3945-devel@lists.sourceforge.net
Subject: Re: [ipw3945-devel] mmotm0812 - something in linux-next killed iwl-3945.c
Date: Thu, 13 Aug 2009 14:19:23 -0400	[thread overview]
Message-ID: <28042.1250187563@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Thu, 13 Aug 2009 13:28:19 EDT." <20090813172819.GD2647@tuxdriver.com>

[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]

On Thu, 13 Aug 2009 13:28:19 EDT, "John W. Linville" said:
> On Thu, Aug 13, 2009 at 12:59:54PM -0400, Valdis.Kletnieks@vt.edu wrote:
> > Build bombs out:
> > 
> >   CC      drivers/net/wireless/iwlwifi/iwl-3945.o
> > drivers/net/wireless/iwlwifi/iwl-3945.c: In function 'iwl3945_pass_packet_to_mac80211':
> > drivers/net/wireless/iwlwifi/iwl-3945.c:580: error: 'hdr' undeclared (first use in this function)
> > drivers/net/wireless/iwlwifi/iwl-3945.c:580: error: (Each undeclared identifier is reported only once
> > drivers/net/wireless/iwlwifi/iwl-3945.c:580: error: for each function it appears in.)
> > make[1]: *** [drivers/net/wireless/iwlwifi/iwl-3945.o] Error 1

> > Sorry, don't have a linux-next git tree, so no 'git blame' for what did it.
> > Hopefully somebody recognizes their handiwork... ;)
> 
> I think this is the LEDS-related build failure, which already has a patch.

Found Kalle Valo's patch removing the #ifdef's in the linux-wireless
archives, build is now proceeding thanks...

Now to figure out how I managed to trip over it, CONFIG_IWLWIFI_LEDS looks
like a config option I would have selected...

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

  reply	other threads:[~2009-08-13 18:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-13 16:59 mmotm0812 - something in linux-next killed iwl-3945.c Valdis.Kletnieks
2009-08-13 17:28 ` [ipw3945-devel] " John W. Linville
2009-08-13 18:19   ` Valdis.Kletnieks [this message]
2009-08-14  4:19   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28042.1250187563@turing-police.cc.vt.edu \
    --to=valdis.kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=ipw3945-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox