Re: [PATCH] Extcon: Minor change in the declaration of cable_names

[함명주 <myungjoo.ham@samsung.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 1699 bytes --]

> From: anish kumar <anish198519851985@gmail.com>
> 
> Instead of "const char **supported_cable" it is better to have
> it as "const char *const *supported_cable".
> 
> Signed-off-by: anish kumar <anish198519851985@gmail.com>

Could you please elaborate on why it's better?

(Is this fixing the using the standard naming issue Mark mentioned before?)


Cheers!
MyungJoo

> ---
>  include/linux/extcon.h                 |    2 +-
>  include/linux/extcon/extcon-adc-jack.h |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/extcon.h b/include/linux/extcon.h
> index cdd4014..a6bcc29 100644
> --- a/include/linux/extcon.h
> +++ b/include/linux/extcon.h
> @@ -111,7 +111,7 @@ struct extcon_cable;
>  struct extcon_dev {
>  	/* --- Optional user initializing data --- */
>  	const char	*name;
> -	const char **supported_cable;
> +	const char *const *supported_cable;
>  	const u32	*mutually_exclusive;
>  
>  	/* --- Optional callbacks to override class functions --- */
> diff --git a/include/linux/extcon/extcon-adc-jack.h b/include/linux/extcon/extcon-adc-jack.h
> index 20e9eef..f27f2e8 100644
> --- a/include/linux/extcon/extcon-adc-jack.h
> +++ b/include/linux/extcon/extcon-adc-jack.h
> @@ -60,7 +60,7 @@ struct adc_jack_pdata {
>  	/*
>  	 * The last entry should be NULL
>  	 */
> -	const char **cable_names;
> +	const char *const *cable_names;
>  	/* The last entry's state should be 0 */
>  	struct adc_jack_cond *adc_conditions;
>  
> -- 
> 1.7.1
> 
> 
> 
> 
>        
>   
>          
> 
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥