* Re: [PATCH] Extcon: Minor change in the declaration of cable_names
@ 2012-08-20 6:56 함명주
2012-08-20 7:27 ` anish kumar
0 siblings, 1 reply; 3+ messages in thread
From: 함명주 @ 2012-08-20 6:56 UTC (permalink / raw)
To: anish kumar; +Cc: 최찬우, linux-kernel@vger.kernel.org
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 1699 bytes --]
> From: anish kumar <anish198519851985@gmail.com>
>
> Instead of "const char **supported_cable" it is better to have
> it as "const char *const *supported_cable".
>
> Signed-off-by: anish kumar <anish198519851985@gmail.com>
Could you please elaborate on why it's better?
(Is this fixing the using the standard naming issue Mark mentioned before?)
Cheers!
MyungJoo
> ---
> include/linux/extcon.h | 2 +-
> include/linux/extcon/extcon-adc-jack.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/extcon.h b/include/linux/extcon.h
> index cdd4014..a6bcc29 100644
> --- a/include/linux/extcon.h
> +++ b/include/linux/extcon.h
> @@ -111,7 +111,7 @@ struct extcon_cable;
> struct extcon_dev {
> /* --- Optional user initializing data --- */
> const char *name;
> - const char **supported_cable;
> + const char *const *supported_cable;
> const u32 *mutually_exclusive;
>
> /* --- Optional callbacks to override class functions --- */
> diff --git a/include/linux/extcon/extcon-adc-jack.h b/include/linux/extcon/extcon-adc-jack.h
> index 20e9eef..f27f2e8 100644
> --- a/include/linux/extcon/extcon-adc-jack.h
> +++ b/include/linux/extcon/extcon-adc-jack.h
> @@ -60,7 +60,7 @@ struct adc_jack_pdata {
> /*
> * The last entry should be NULL
> */
> - const char **cable_names;
> + const char *const *cable_names;
> /* The last entry's state should be 0 */
> struct adc_jack_cond *adc_conditions;
>
> --
> 1.7.1
>
>
>
>
>
>
>
>
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Extcon: Minor change in the declaration of cable_names
2012-08-20 6:56 [PATCH] Extcon: Minor change in the declaration of cable_names 함명주
@ 2012-08-20 7:27 ` anish kumar
0 siblings, 0 replies; 3+ messages in thread
From: anish kumar @ 2012-08-20 7:27 UTC (permalink / raw)
To: myungjoo.ham
Cc: 최찬우, linux-kernel@vger.kernel.org,
Lars-Peter Clausen
On Mon, 2012-08-20 at 06:56 +0000, 함명주 wrote:
> > From: anish kumar <anish198519851985@gmail.com>
> >
> > Instead of "const char **supported_cable" it is better to have
> > it as "const char *const *supported_cable".
> >
> > Signed-off-by: anish kumar <anish198519851985@gmail.com>
>
> Could you please elaborate on why it's better?
>
> (Is this fixing the using the standard naming issue Mark mentioned before?)
No, It is what Lars(Lars-Peter Clausen) mentioned when he was doing the
review earlier.It is nothing but a general practise as cable_names is
constant.
>
>
> Cheers!
> MyungJoo
>
> > ---
> > include/linux/extcon.h | 2 +-
> > include/linux/extcon/extcon-adc-jack.h | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/extcon.h b/include/linux/extcon.h
> > index cdd4014..a6bcc29 100644
> > --- a/include/linux/extcon.h
> > +++ b/include/linux/extcon.h
> > @@ -111,7 +111,7 @@ struct extcon_cable;
> > struct extcon_dev {
> > /* --- Optional user initializing data --- */
> > const char *name;
> > - const char **supported_cable;
> > + const char *const *supported_cable;
> > const u32 *mutually_exclusive;
> >
> > /* --- Optional callbacks to override class functions --- */
> > diff --git a/include/linux/extcon/extcon-adc-jack.h b/include/linux/extcon/extcon-adc-jack.h
> > index 20e9eef..f27f2e8 100644
> > --- a/include/linux/extcon/extcon-adc-jack.h
> > +++ b/include/linux/extcon/extcon-adc-jack.h
> > @@ -60,7 +60,7 @@ struct adc_jack_pdata {
> > /*
> > * The last entry should be NULL
> > */
> > - const char **cable_names;
> > + const char *const *cable_names;
> > /* The last entry's state should be 0 */
> > struct adc_jack_cond *adc_conditions;
> >
> > --
> > 1.7.1
> >
> >
> >
> >
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Extcon: Minor change in the declaration of cable_names
@ 2012-08-18 8:19 anish kumar
0 siblings, 0 replies; 3+ messages in thread
From: anish kumar @ 2012-08-18 8:19 UTC (permalink / raw)
To: myungjoo.ham; +Cc: cw00.choi, linux-kernel, anish kumar
From: anish kumar <anish198519851985@gmail.com>
Instead of "const char **supported_cable" it is better to have
it as "const char *const *supported_cable".
Signed-off-by: anish kumar <anish198519851985@gmail.com>
---
include/linux/extcon.h | 2 +-
include/linux/extcon/extcon-adc-jack.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/extcon.h b/include/linux/extcon.h
index cdd4014..a6bcc29 100644
--- a/include/linux/extcon.h
+++ b/include/linux/extcon.h
@@ -111,7 +111,7 @@ struct extcon_cable;
struct extcon_dev {
/* --- Optional user initializing data --- */
const char *name;
- const char **supported_cable;
+ const char *const *supported_cable;
const u32 *mutually_exclusive;
/* --- Optional callbacks to override class functions --- */
diff --git a/include/linux/extcon/extcon-adc-jack.h b/include/linux/extcon/extcon-adc-jack.h
index 20e9eef..f27f2e8 100644
--- a/include/linux/extcon/extcon-adc-jack.h
+++ b/include/linux/extcon/extcon-adc-jack.h
@@ -60,7 +60,7 @@ struct adc_jack_pdata {
/*
* The last entry should be NULL
*/
- const char **cable_names;
+ const char *const *cable_names;
/* The last entry's state should be 0 */
struct adc_jack_cond *adc_conditions;
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-08-20 7:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-20 6:56 [PATCH] Extcon: Minor change in the declaration of cable_names 함명주
2012-08-20 7:27 ` anish kumar
-- strict thread matches above, loose matches on Subject: below --
2012-08-18 8:19 anish kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).