public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Menglong Dong <menglong.dong@linux.dev>
To: Menglong Dong <menglong8.dong@gmail.com>, Song Liu <song@kernel.org>
Cc: ast@kernel.org, song@kernel.org, daniel@iogearbox.net,
	john.fastabend@gmail.com, andrii@kernel.org,
	martin.lau@linux.dev, eddyz87@gmail.com, yonghong.song@linux.dev,
	kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com,
	jolsa@kernel.org, jiang.biao@linux.dev, bpf@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf] bpf: handle the return of ftrace_set_filter_ip in register_fentry
Date: Tue, 11 Nov 2025 08:59:10 +0800	[thread overview]
Message-ID: <2806193.mvXUDI8C0e@7950hx> (raw)
In-Reply-To: <CAHzjS_vj26p7SwVupAb0XyTZs__NProJ+CN6DKy+-E1R+Wk33Q@mail.gmail.com>

On 2025/11/10 23:49, Song Liu wrote:
> On Mon, Nov 10, 2025 at 4:07 AM Menglong Dong <menglong8.dong@gmail.com> wrote:
> >
> > The error that returned by ftrace_set_filter_ip() in register_fentry() is
> > not handled properly. Just fix it.
> >
> > Fixes: 00963a2e75a8 ("bpf: Support bpf_trampoline on functions with IPMODIFY (e.g. livepatch)")
> > Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>
> > ---
> >  kernel/bpf/trampoline.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> LGTM. Thanks for the fix!
> 
> Acked-by: Song Liu <song@kernel.org>
> 
> Can we add a test for this code path?

I think it can be done by attach a fentry to a notrace function and
check the error number.

Let me have a try.

> 
> Song
> 
> 





  reply	other threads:[~2025-11-11  0:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-10 12:07 [PATCH bpf] bpf: handle the return of ftrace_set_filter_ip in register_fentry Menglong Dong
2025-11-10 15:49 ` Song Liu
2025-11-11  0:59   ` Menglong Dong [this message]
2025-11-11  3:17     ` Menglong Dong
2025-11-14 21:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2806193.mvXUDI8C0e@7950hx \
    --to=menglong.dong@linux.dev \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=haoluo@google.com \
    --cc=jiang.biao@linux.dev \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=menglong8.dong@gmail.com \
    --cc=sdf@fomichev.me \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox