From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754132AbbK0Nc4 (ORCPT ); Fri, 27 Nov 2015 08:32:56 -0500 Received: from gloria.sntech.de ([95.129.55.99]:50497 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978AbbK0Ncy convert rfc822-to-8bit (ORCPT ); Fri, 27 Nov 2015 08:32:54 -0500 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Yakir Yang Cc: Inki Dae , Andrzej Hajda , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Jingoo Han , Thierry Reding , Krzysztof Kozlowski , Rob Herring , Mark Yao , Russell King , djkurtz@chromium.org, dianders@chromium.org, Sean Paul , Kukjin Kim , Kumar Gala , emil.l.velikov@gmail.com, Ian Campbell , Gustavo Padovan , Kishon Vijay Abraham I , Pawel Moll , ajaynumb@gmail.com, robherring2@gmail.com, javier@osg.samsung.com, Andy Yan , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v8 14/17] drm: bridge: analogix/dp: add max link rate and lane count limit for RK3288 Date: Fri, 27 Nov 2015 14:32:26 +0100 Message-ID: <2807882.UeSPH80il3@diego> User-Agent: KMail/4.14.10 (Linux/4.2.0-1-amd64; KDE/4.14.12; x86_64; ; ) In-Reply-To: <1446022561-16870-1-git-send-email-ykk@rock-chips.com> References: <1446020143-32645-1-git-send-email-ykk@rock-chips.com> <1446022561-16870-1-git-send-email-ykk@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 28. Oktober 2015, 16:56:01 schrieb Yakir Yang: > There are some IP limit on rk3288 that only support 4 physical lanes > of 2.7/1.6 Gbps/lane, so seprate them out by device_type flag. > > Tested-by: Javier Martinez Canillas > Signed-off-by: Yakir Yang > --- [...] > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index > 6307060..563ffb1d 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > @@ -890,8 +890,8 @@ static void analogix_dp_commit(struct analogix_dp_device > *dp) return; > } > > - ret = analogix_dp_set_link_train(dp, dp->video_info.lane_count, > - dp->video_info.link_rate); > + ret = analogix_dp_set_link_train(dp, dp->video_info.max_lane_count, > + dp->video_info.max_link_rate); > if (ret) { > dev_err(dp->dev, "unable to do link train\n"); > return; > @@ -1156,16 +1156,25 @@ static int analogix_dp_dt_parse_pdata(struct > analogix_dp_device *dp) struct device_node *dp_node = dp->dev->of_node; > struct video_info *video_info = &dp->video_info; > > - if (of_property_read_u32(dp_node, "samsung,link-rate", > - &video_info->link_rate)) { > - dev_err(dp->dev, "failed to get link-rate\n"); > - return -EINVAL; > - } > - > - if (of_property_read_u32(dp_node, "samsung,lane-count", > - &video_info->lane_count)) { > - dev_err(dp->dev, "failed to get lane-count\n"); > - return -EINVAL; > + switch (dp->plat_data && dp->plat_data->dev_type) { drivers/gpu/drm/bridge/analogix/analogix_dp_core.c: In function ‘analogix_dp_dt_parse_pdata’: drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1191:10: warning: switch condition has boolean value [-Wswitch-bool] switch (dp->plat_data && dp->plat_data->dev_type) { ^ As I think we always will need to distinguish between implementations, I guess it should be safe to exit with an error, it that implementation-data is not available, like just doing before the switch a: if (!dp->plat_data) return -EINVAL; Heiko