From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965010AbbDQP43 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 17 Apr 2015 11:56:29 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:63044 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932802AbbDQP40 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 17 Apr 2015 11:56:26 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        Baruch Siach <baruch@tkos.co.il>,
        Russell King - ARM Linux <linux@arm.linux.org.uk>,
        Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH v3 3/4] ARM: dts: UniPhier: add support for UniPhier SoCs and boards
Date: Fri, 17 Apr 2015 17:56:02 +0200
Message-ID: <2809229.iRV9NgGGKe@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1429285698-11829-4-git-send-email-yamada.masahiro@socionext.com>
References: <1429285698-11829-1-git-send-email-yamada.masahiro@socionext.com> <1429285698-11829-4-git-send-email-yamada.masahiro@socionext.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:wwmoitSDgwxxYy3xip6gMA1FF6GrnCJRLaAyLGGU7TGbZeauvdh
 X601hSF+m63Mgn5+d9KhUE4FWh0lfDwWWpepxTAc/rHu4KChV+/tTg4vgnBQkVRZoR+QxKW
 r41HLq1HyqHFPOE25+iZrG8ncm2Kl8hiWBCM9QtJRrGo9dh4oAknx16ymlkbR9GEnBCUkpk
 Sp4m7BBra/XKjpYQoSVeQ==
X-UI-Out-Filterresults: notjunk:1;
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Saturday 18 April 2015 00:48:17 Masahiro Yamada wrote:
> +
> +               smp_syscon@59801208 {
> +                       compatible = "socionext,uniphier-smp-reg", "syscon";
> +                       reg = <0x59801208 0x4>;
> +               };
> +
> 

Using syscon here is a good idea, but please name the register area
according to what it is called in the data sheet, not according to how
it is used in Linux, and list all the registers that belong in this
device. It's quite possible that another driver needs a second
register from the same syscon.

E.g. if there is a device called a foo controller, make this device

	foo-controller@0x59800000 {
		compatible = "socionext,uniphier-foo-controller", "syscon";
		reg = <0x59800000 0x4000>;
	};

then hardcode the 0x1208 offset in the smp code, or add it as an
argument to the property containing the phandle.

	Arnd