From: David Howells <dhowells@redhat.com>
To: chuck.lever@oracle.com
Cc: dhowells@redhat.com, Trond.Myklebust@netapp.com,
nfsv4@linux-nfs.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 24/27] NFS: Use local caching [try #2]
Date: Thu, 07 Feb 2008 10:57:49 +0000 [thread overview]
Message-ID: <28135.1202381869@redhat.com> (raw)
In-Reply-To: <479901A8.3000706@oracle.com>
Chuck Lever <chuck.lever@oracle.com> wrote:
> > @@ -95,12 +100,25 @@ struct nfs_server {
> > unsigned int acdirmin;
> > unsigned int acdirmax;
> > unsigned int namelen;
> > + unsigned int options; /* extra options enabled by mount */
> > +#define NFS_OPTION_FSCACHE 0x00000001 /* - local caching enabled */
>
> Why did you choose to create a new field for this rather than setting up a new
> NFS_MNT flag? The new in-kernel NFS mount option parser uses the NFS_MNT
> flags too.
There aren't any NFS_MNT flags, so I presume you mean NFS_MOUNT flags. As I
understood Trond, it's not permitted to add new such flags except in really
special circumstances as these are part of the mount syscall interface. I
took this to mean that I should record the option elsewhere than in
server->flags.
David
next prev parent reply other threads:[~2008-02-07 10:58 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 17:20 [PATCH 00/27] Permit filesystem local caching [try #2] David Howells
2008-01-23 17:20 ` [PATCH 01/27] KEYS: Increase the payload size when instantiating a key " David Howells
2008-01-23 17:20 ` [PATCH 02/27] KEYS: Check starting keyring as part of search " David Howells
2008-01-23 17:20 ` [PATCH 03/27] KEYS: Allow the callout data to be passed as a blob rather than a string " David Howells
2008-01-23 17:21 ` [PATCH 04/27] KEYS: Add keyctl function to get a security label " David Howells
2008-01-23 17:21 ` [PATCH 05/27] Security: Change current->fs[ug]id to current_fs[ug]id() " David Howells
2008-01-23 17:21 ` [PATCH 06/27] Security: Separate task security context from task_struct " David Howells
2008-01-23 17:21 ` [PATCH 07/27] Security: De-embed task security record from task and use refcounting " David Howells
2008-01-23 17:21 ` [PATCH 08/27] Add a secctx_to_secid() LSM hook to go along with the existing " David Howells
2008-01-23 17:21 ` [PATCH 09/27] Security: Pre-add additional non-caching classes " David Howells
2008-01-23 17:21 ` [PATCH 10/27] Security: Add a kernel_service object class to SELinux " David Howells
2008-01-23 17:21 ` [PATCH 11/27] Security: Allow kernel services to override LSM settings for task actions " David Howells
2008-01-23 17:21 ` [PATCH 12/27] Security: Make NFSD work with detached security " David Howells
2008-01-23 17:21 ` [PATCH 13/27] FS-Cache: Release page->private after failed readahead " David Howells
2008-01-23 17:21 ` [PATCH 14/27] FS-Cache: Recruit a couple of page flags for cache management " David Howells
2008-01-23 17:21 ` [PATCH 15/27] FS-Cache: Provide an add_wait_queue_tail() function " David Howells
2008-01-23 17:22 ` [PATCH 16/27] FS-Cache: Generic filesystem caching facility " David Howells
2008-01-23 17:22 ` [PATCH 17/27] CacheFiles: Add missing copy_page export for ia64 " David Howells
2008-01-23 17:22 ` [PATCH 18/27] CacheFiles: Be consistent about the use of mapping vs file->f_mapping in Ext3 " David Howells
2008-01-23 17:22 ` [PATCH 19/27] CacheFiles: Add a hook to write a single page of data to an inode " David Howells
2008-01-23 17:22 ` [PATCH 20/27] CacheFiles: Permit the page lock state to be monitored " David Howells
2008-01-23 17:22 ` [PATCH 21/27] CacheFiles: Export things for CacheFiles " David Howells
2008-01-23 17:22 ` [PATCH 22/27] CacheFiles: A cache that backs onto a mounted filesystem " David Howells
2008-01-23 17:22 ` [PATCH 23/27] NFS: Fix memory leak " David Howells
2008-01-24 21:15 ` Trond Myklebust
2008-01-23 17:22 ` [PATCH 24/27] NFS: Use local caching " David Howells
2008-01-24 21:08 ` Trond Myklebust
2008-01-24 21:22 ` Chuck Lever
2008-01-30 3:25 ` David Howells
2008-01-30 6:46 ` Trond Myklebust
2008-01-30 22:36 ` Chuck Lever
2008-01-31 23:29 ` David Howells
2008-02-07 10:57 ` David Howells [this message]
2008-01-23 17:22 ` [PATCH 25/27] NFS: Configuration and mount option changes to enable local caching on NFS " David Howells
2008-01-24 21:14 ` Trond Myklebust
2008-01-23 17:22 ` [PATCH 26/27] NFS: Display local caching state " David Howells
2008-01-23 17:23 ` [PATCH 27/27] NFS: Separate caching by superblock, explicitly if necessary " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28135.1202381869@redhat.com \
--to=dhowells@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=chuck.lever@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox