From: David Howells <dhowells@redhat.com>
To: Shyam Prasad N <nspmangalore@gmail.com>
Cc: dhowells@redhat.com, Shyam Prasad N <sprasad@microsoft.com>,
Steve French <smfrench@gmail.com>,
Rohith Surabattula <rohiths.msft@gmail.com>,
Paulo Alcantara <pc@manguebit.com>, Tom Talpey <tom@talpey.com>,
Jeff Layton <jlayton@kernel.org>,
linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cifs: Fix cifs_limit_bvec_subset() to correctly check the maxmimum size
Date: Mon, 22 May 2023 19:11:01 +0100 [thread overview]
Message-ID: <2818727.1684779061@warthog.procyon.org.uk> (raw)
In-Reply-To: <CANT5p=pNFpEj0p+njYw3sVdq9CKgsTdh29Gj6iYDOsMN0ocj1Q@mail.gmail.com>
Shyam Prasad N <nspmangalore@gmail.com> wrote:
> > + max_size -= len;
>
> Shouldn't this decrement happen below, after the span has been
> compared with max_size?
It probably doesn't matter. The compiler is free to move it around, but yes
that and ix++ can both be moved down.
David
next prev parent reply other threads:[~2023-05-22 18:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 14:40 [PATCH] cifs: Fix cifs_limit_bvec_subset() to correctly check the maxmimum size David Howells
2023-05-22 17:28 ` Shyam Prasad N
2023-05-22 18:11 ` David Howells [this message]
2023-05-23 6:45 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2818727.1684779061@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=pc@manguebit.com \
--cc=rohiths.msft@gmail.com \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox