From: "Heiko Stübner" <heiko@sntech.de>
To: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] power: generic-adc-battery: return meaningful error when no channel available
Date: Fri, 16 May 2014 15:14:20 +0200 [thread overview]
Message-ID: <2822261.bmyft01XjZ@phil> (raw)
In-Reply-To: <3453746.GBc4Nvx1gU@phil>
From: Heiko Stuebner <heiko.stuebner@bq.com>
When no channel was found the driver currently always returns -ENODEV. This
hides the actual error which is available in ret from the kernel and disables
for example -EPROBE_DEFER handling.
Signed-off-by: Heiko Stuebner <heiko.stuebner@bq.com>
---
drivers/power/generic-adc-battery.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/power/generic-adc-battery.c b/drivers/power/generic-adc-battery.c
index 540d57f..02f434b 100644
--- a/drivers/power/generic-adc-battery.c
+++ b/drivers/power/generic-adc-battery.c
@@ -297,10 +297,8 @@ static int gab_probe(struct platform_device *pdev)
}
/* none of the channels are supported so let's bail out */
- if (index == 0) {
- ret = -ENODEV;
+ if (index == 0)
return ret;
- }
/*
* Total number of properties is equal to static properties
--
1.9.0
next prev parent reply other threads:[~2014-05-16 13:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 13:12 [PATCH 1/2] power: generic-adc-battery: use devm_kcalloc for psy->properties Heiko Stübner
2014-05-16 13:14 ` Heiko Stübner [this message]
2014-07-07 11:46 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2822261.bmyft01XjZ@phil \
--to=heiko@sntech.de \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox