From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F370A12CDA5 for ; Wed, 17 Apr 2024 09:03:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713344588; cv=none; b=YNN4WhGFH5ELOCnYoWbg3XA6sntPo5Uoili8+v4BXrNz9p3+a9M/GqNP9tOZK/1xgm8851agvC35KFAqRL5Mowgmg2O3KCxXY/EwtiuNhGmH/zLjFLjiJfdjf6loy6lE1eiiaj3I5GfC9ioV772wnzn2invZczAcpBSg6TxC7hU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713344588; c=relaxed/simple; bh=R4xZIyD420GCJPk7IwQrpmZ24e54I/xuenwhI6qQfh8=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=T0W4dMjR9yWsZVfoWtTou0cCW7Zkauou/uvGMtA9/b5tMUORIYotHbyi5Sw/q/Oh3i9Zto4iCk0e5puu/Nhe95QQSP3NmFQDxvVwszByddS+RDqZotsDw9ECqVyr2dErRMJpjLHDgFi5WXyr6W8oa2sdf/IL2zdzJ3sOrV8AaXQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=d/f0SHMZ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="d/f0SHMZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713344586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+cqHolZFVcFPpeLBdV05ZqicpNbJqZRKW17Kvjt/Abs=; b=d/f0SHMZN64k9uuHgJ/2oBnlsNJIrr7j+CE683Ft8JTfXTXXiYdTxg6g4T1EqDKFAIVPsj fpfUsQuB6aNeLfqPKGT+40Hnos7kvtUelc1G/u4CFInKFXT11d1+94T2KPc8KRkf7njsTt bPGRgqG5ZOWqWhvWAZ0nTrC9O7y+GJo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-455-UAKkPT0cNTu8x3FwjUWu1g-1; Wed, 17 Apr 2024 05:03:00 -0400 X-MC-Unique: UAKkPT0cNTu8x3FwjUWu1g-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D56BA10499A0; Wed, 17 Apr 2024 09:02:58 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.200]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6F32BC13FA2; Wed, 17 Apr 2024 09:02:53 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <3570373a3db66151033a3667cb8c28bbf8bc505b.camel@kernel.org> References: <3570373a3db66151033a3667cb8c28bbf8bc505b.camel@kernel.org> <20240328163424.2781320-1-dhowells@redhat.com> <20240328163424.2781320-10-dhowells@redhat.com> To: Jeff Layton Cc: David Howells , Christian Brauner , Gao Xiang , Dominique Martinet , Matthew Wilcox , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Miklos Szeredi , Trond Myklebust , Christoph Hellwig , Andrew Morton , Alexander Viro , Christian Brauner , devel@lists.orangefs.org Subject: Re: [PATCH 09/26] mm: Provide a means of invalidation without using launder_folio Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <28262.1713344568.1@warthog.procyon.org.uk> Date: Wed, 17 Apr 2024 10:02:48 +0100 Message-ID: <28263.1713344568@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 Jeff Layton wrote: > I'd have liked to have seen the first caller of this function too. Looking again at my code, I also need to make netfs_unbuffered_write_iter() use this function too. I missed it before because that wasn't calling invalidate_inode_pages2_range() directly, but rather going through kiocb_invalidate_pages(). So I'll add those changes into this patch to give you a first caller. I also then need to make filemap_invalidate_inode() take a byte range. David