From: David Howells <dhowells@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Hugh Dickins <hugh@veritas.com>,
Brian Pomerantz <bapper@piratehaven.org>,
viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org,
Nick Piggin <nickpiggin@yahoo.com.au>
Subject: Re: [PATCH] fix page leak during core dump
Date: Sat, 31 Mar 2007 13:57:29 +0100 [thread overview]
Message-ID: <2828.1175345849@redhat.com> (raw)
In-Reply-To: <20070330151353.95cd56ed.akpm@linux-foundation.org>
Andrew Morton <akpm@linux-foundation.org> wrote:
> <would anyone be interested in hearing my opinion on the DUMP_SEEK macro
> again?>
I can guess. And it's very probably right. Macros containing return
statements like that are dodgy as they help people screw up the error handling.
However, ...
Andrew Morton <akpm@linux-foundation.org> wrote:
> - DUMP_SEEK(file->f_pos + PAGE_SIZE);
> - page_cache_release(page);
> + if (!dump_seek(file, file->f_pos + PAGE_SIZE)) {
> + page_cache_release(page);
> + return 0;
> + }
Is not correct as you've then eliminated the page_cache_release() on the
success path. What you probably intended was:
int tmp;
...
tmp = dump_seek(file, file->f_pos + PAGE_SIZE);
page_cache_release(page);
if (!tmp)
return 0;
David
prev parent reply other threads:[~2007-03-31 12:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-29 20:39 [PATCH] fix page leak during core dump Brian Pomerantz
2007-03-30 20:43 ` Andrew Morton
2007-03-30 22:01 ` Hugh Dickins
2007-03-30 22:13 ` Andrew Morton
2007-03-30 23:06 ` Hugh Dickins
2007-03-31 12:59 ` David Howells
2007-03-31 12:57 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2828.1175345849@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bapper@piratehaven.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox