From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752180AbdJKOMt (ORCPT ); Wed, 11 Oct 2017 10:12:49 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35466 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751587AbdJKOMr (ORCPT ); Wed, 11 Oct 2017 10:12:47 -0400 X-Google-Smtp-Source: AOwi7QB4JMAHwYkU8YRI60pMewGPMA0QjYmk/GnyrYjJJXu62WCdTNOVAW/Jt7E9FgfhL3+MYOZlfQ== Subject: Re: [PATCH][net-next] net: mpls: make function ipgre_mpls_encap_hlen static To: Colin King , "David S . Miller" , Robert Shearman , Roopa Prabhu , netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Amine Kherbouche References: <20171011095328.17546-1-colin.king@canonical.com> From: David Ahern Message-ID: <282bd0a3-4cf6-4269-c07f-a476aa0bb764@gmail.com> Date: Wed, 11 Oct 2017 08:12:34 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171011095328.17546-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/11/17 3:53 AM, Colin King wrote: > From: Colin Ian King > > The function ipgre_mpls_encap_hlen is local to the source and > does not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'ipgre_mpls_encap_hlen' was not declared. Should it be static? > Fixes: bdc476413dcdb ("ip_tunnel: add mpls over gre support") > Signed-off-by: Colin Ian King > --- > net/mpls/af_mpls.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c > index 9745e8f69810..8ca9915befc8 100644 > --- a/net/mpls/af_mpls.c > +++ b/net/mpls/af_mpls.c > @@ -41,7 +41,7 @@ static int label_limit = (1 << 20) - 1; > static int ttl_max = 255; > > #if IS_ENABLED(CONFIG_NET_IP_TUNNEL) > -size_t ipgre_mpls_encap_hlen(struct ip_tunnel_encap *e) > +static size_t ipgre_mpls_encap_hlen(struct ip_tunnel_encap *e) > { > return sizeof(struct mpls_shim_hdr); > } > Acked-by: David Ahern