From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753630AbcEXJuR (ORCPT ); Tue, 24 May 2016 05:50:17 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:59771 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750797AbcEXJuP (ORCPT ); Tue, 24 May 2016 05:50:15 -0400 From: Laurent Pinchart To: Vinod Koul Cc: Kuninori Morimoto , Geert Uytterhoeven , Laurent Pinchart , sakato , OSD2 ML , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dma: rcar-dmac: use list_add() on rcar_dmac_desc_put() Date: Tue, 24 May 2016 12:50:28 +0300 Message-ID: <2831766.dEtRrr4FvR@avalon> User-Agent: KMail/4.14.10 (Linux/4.4.6-gentoo; KDE/4.14.16; x86_64; ; ) In-Reply-To: <20160514075731.GA23734@localhost> References: <87r3dywh6u.wl%kuninori.morimoto.gx@renesas.com> <20160514075731.GA23734@localhost> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vinod, On Saturday 14 May 2016 13:27:31 Vinod Koul wrote: > On Fri, Apr 22, 2016 at 01:50:04AM +0000, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > > > Current rcar_dmac_desc_put() is using list_add_tail() in order to > > push used descriptor to list of free descriptors, and next DMA transfer > > try to reuse it from this list. But because it is using *_tail(), > > this reuse effect can't be obtained without using all of them. > > For a longer-term solution, we should allocate hardware descriptors > > using GFP_KERNEL instead of GFP_NOWAIT, but it is difficult today. > > This patch uses list_add() instead of list_add_tail() for short-term > > solution. > > Applied, thanks Thanks, but where did you apply it to ? I can't find it in your tree. -- Regards, Laurent Pinchart