Re: Can't compile 2.4.3 with agcc

[David Woodhouse <dwmw2@infradead.org>]

matan@svgalib.org said:
>  This is known at compile time, right? Would it not be better to
> replace the printk with #error ? Why do I need to boot the bad kernel
> to find out that it does not work, when it is known when compiling? 

It's known at compile time, but not at preprocessing time, so it can't be 
done with #error. If you can come up with a way of doing it at compile time 
such that:

 1. It's _guaranteed_ to work when the compiler does align the members 
	of the structure as we desire.
 2. It gives a message sufficiently informative that it prevents further
	such reports getting to l-k.

... then I agree, it would be better to do it at compile time. If not, the 
runtime check is the best we can do.

We really ought to have learned by now that we shouldn't be relying on the 
observed behaviour of this week's compiler in this particular phase of the 
moon.

--
dwmw2