From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx-relay05-hz1.antispameurope.com (mx-relay05-hz1.antispameurope.com [94.100.132.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D34473128C3 for ; Fri, 12 Dec 2025 09:52:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=94.100.132.205 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765533128; cv=pass; b=ZsgZLn2VYy8VExHI0JfWhW4RhqJWHA9bp21EML+v9vDBzJbuY9y5slvQTroAJy18ehl1MR9wmJZDt8CB/lBU0WutOHrraQKKbZmLIdquz27c0bDcDummCrOalpDcz10DvasN+alBcde1a4kxk4Gy/d/lh3yFu9yhlPaF7XXfXvQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765533128; c=relaxed/simple; bh=TI2m61YBdl1GMQceR2JhbMYVuSEl8a3zN/NO8asmOiQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IJzV4fhS+z1JQPDSEUnnD3Msnf9XQExPSF19l5U5Cjez/snkT/xgEE+ItvjkASvDjqa8AFEt1+K3pzHaXaUhV1QX2c5SMAfnaEWJ1cqv1IMWa2C7u1MNHh1oR+fAGELchjG7xwGb/djURz7Ceix92fNcl6QZtHVIzugZcgfLezY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ew.tq-group.com; spf=pass smtp.mailfrom=ew.tq-group.com; dkim=pass (2048-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b=CAgUefop; arc=pass smtp.client-ip=94.100.132.205 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="CAgUefop" ARC-Authentication-Results: i=1; mx-gate05-hz1.hornetsecurity.com 1; spf=pass reason=mailfrom (ip=94.100.132.6, headerfrom=ew.tq-group.com) smtp.mailfrom=ew.tq-group.com smtp.helo=hmail-p-smtp01-out03-hz1.hornetsecurity.com; dmarc=pass header.from=ew.tq-group.com orig.disposition=pass ARC-Message-Signature: a=rsa-sha256; bh=rw8v+O9ISmv417db9VXquH0YDhWPpp5IanaI43t8fTQ=; c=relaxed/relaxed; d=hornetsecurity.com; h=from:to:date:subject:mime-version:; i=1; s=hse1; t=1765533083; b=Hd9GLiJYrCRganvdklIArQSt/2t9txoHQ2+0R+Ri8a6cEikIM3uaDPEarv/HWhxols0YxCWz PGfH2DwnAYtVw/tWi0CvoIh5BXWSI7j2EqRqaaz3c/p7R2hQNVONWZiBVRe/o3t/7yK6FwhGb8d YsElqRBgnF0G+yuAQPdKUSwXVRU8Zh11h3dp7+cNQPtdwlFGw6LHXhernhG1b7Gf2rT0ycpokj5 Sf4e0s5ELvdl10lYErRo7SId0KpYKpjntJ5VehpaPxwJsogeYHlvMb2xWHji3nofsZZydvD+4F8 BEJCCSNm2IEF08PAoGLxLP1OaQIYtQctFGkYZ0dJI6I0Q== ARC-Seal: a=rsa-sha256; cv=none; d=hornetsecurity.com; i=1; s=hse1; t=1765533083; b=XbyeTRb0gPFvDv2O47TGo2DHmlHfkHF2bQ7q+kCBOEK4derMGNpf2gHNidqnOtPaI3489sLR +dcPzdwSXwagcIJim1XgXFsmRZqpiddc4n4ZMwRRA9cwCoQ5C7yG8laRe3PwXqVyPwf4eTkrvbw hkMBjiX1QqeeLTUepOCSwFCHON44AvhFukK3bV8sw6e21ZFhIMJ3g4j8t3drlS4vHVf4SoOPPOW Zz9/lomfddHYWDYb/d6t9QSb7xVfUx47Tqu6NtQ/lZIM5uj7dILfFCQS7gbUV+gzMc5WuWslR/r 2TzT5MhiseHFwlHu5Z3zVnZQwKq9VUTpzHFMbfU9z26CA== Received: from he-nlb01-hz1.hornetsecurity.com ([94.100.132.6]) by mx-relay05-hz1.antispameurope.com; Fri, 12 Dec 2025 10:51:23 +0100 Received: from steina-w.localnet (host-82-135-125-110.customer.m-online.net [82.135.125.110]) (Authenticated sender: alexander.stein@ew.tq-group.com) by hmail-p-smtp01-out03-hz1.hornetsecurity.com (Postfix) with ESMTPSA id 403BFCC0E89; Fri, 12 Dec 2025 10:51:13 +0100 (CET) From: Alexander Stein To: Ioana Ciornei , Ulf Hansson , Geert Uytterhoeven , Johan Hovold , "Rafael J. Wysocki" , "Rob Herring (Arm)" , Greg Kroah-Hartman , Thomas Gleixner Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] irqchip/ls-extirq: convert to a platform driver Date: Fri, 12 Dec 2025 10:51:12 +0100 Message-ID: <2841754.mvXUDI8C0e@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <87qzt0eblo.ffs@tglx> References: <20251205155735.2366732-1-ioana.ciornei@nxp.com> <20251205155735.2366732-2-ioana.ciornei@nxp.com> <87qzt0eblo.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart12828583.O9o76ZdvQC"; micalg="pgp-sha512"; protocol="application/pgp-signature" X-cloud-security-sender:alexander.stein@ew.tq-group.com X-cloud-security-recipient:linux-kernel@vger.kernel.org X-cloud-security-crypt: load encryption module X-cloud-security-Mailarchiv: E-Mail archived for: alexander.stein@ew.tq-group.com X-cloud-security-Mailarchivtype:outbound X-cloud-security-Virusscan:CLEAN X-cloud-security-disclaimer: This E-Mail was scanned by E-Mailservice on mx-relay05-hz1.antispameurope.com with 4dSPq55950zYq52 X-cloud-security-connect: he-nlb01-hz1.hornetsecurity.com[94.100.132.6], TLS=1, IP=94.100.132.6 X-cloud-security-Digest:7f9ff6c280e85d3a2e959bc2c038ad53 X-cloud-security:scantime:1.864 DKIM-Signature: a=rsa-sha256; bh=rw8v+O9ISmv417db9VXquH0YDhWPpp5IanaI43t8fTQ=; c=relaxed/relaxed; d=ew.tq-group.com; h=content-type:mime-version:subject:from:to:message-id:date; s=hse1; t=1765533082; v=1; b=CAgUefopT4Y7V+QKbY8ZS409g+aXUTzRAGkkN5enYT+KN2W6+E3rtmXq/JjHlrZK1ekDx6aj kYYS4C59p3APo1NvBOLBlajQxgVla6HFtpp7lnEPYX4km6LUErsMN/t5y7Z50qt5Dn/bo3Zos7Z m/X7BH3QjQAFsorfDKFEHoONB5LuqtCQL1RToCUtwSYRQwSHWzM7lx5shjboIOow92hKImbdJPo OeOvbadxILIQ5xhpC/HSSP9eW0RIYUSDaP2O2sioMrSI6djonrpGVU2W8Lm0EEOds5qSxOgnwZT 6epkfVlYQ58ZmwBlqhr2sJY66fs3valkr61/1cAV2xmVQ== --nextPart12828583.O9o76ZdvQC Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; protected-headers="v1" From: Alexander Stein Cc: linux-kernel@vger.kernel.org Date: Fri, 12 Dec 2025 10:51:12 +0100 Message-ID: <2841754.mvXUDI8C0e@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <87qzt0eblo.ffs@tglx> MIME-Version: 1.0 Hi, thanks for bringing this to me. Am Freitag, 12. Dezember 2025, 02:24:19 CET schrieb Thomas Gleixner: > On Fri, Dec 05 2025 at 17:57, Ioana Ciornei wrote: > > Since there is no need for ls-extirq to be initialized early, convert it > > to a proper platform driver. Instead of using IRQCHIP_DECLARE, add an > > of_device_id array with the same compatible strings as before. Also > > change the prototype and name of the probe function and adjust it to a > > platform_device structure. > > > > With this change we also have the added advantage of avoiding the > > irqchip_init() -> of_irq_init() code path which imposes dt checks that > > the ls-extirq does not comply with because of its improper use of the > > interrupt-map property. > > > > Fixes: 1b1f04d8271e ("of/irq: Ignore interrupt parent for nodes without= interrupts") >=20 > I'm not seeing how that Fixes tag is related. Your changelog clearly > lacks a proper explanation. >=20 > Aside of that there is this series: >=20 > https://lore.kernel.org/20251201105144.539450-1-alexander.stein@ew.= tq-group.com >=20 > which is way more complete and cleans up the thing nicely instead of > just converting it to a platform driver with minimal effort. There is still one open question: How to deal with the scfg/isc nodes? Use patch 2/2 of this series to make them additional pm-busses or move the ls-ext-irq nodes outside of it? Best regards, Alexander =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ --nextPart12828583.O9o76ZdvQC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEByESxqszIvkmWRwbaS+g2M0Z/iUFAmk75ZAACgkQaS+g2M0Z /iVXCwgApFL2YdXW/buXr9SsQVibrQYNyBATJsfveDJ+XJtBUNnnArPS5i3cAWTo ewRAv1fhiVTcHLRbEPD5eZlQHj3StlitpUgA/sh49DM9WHe0JyXuBYyYjzVEpu1t wJFdiFHj9Yt3ztxuo90vTwM7eMsWcatycICERr/IqtGsKBj0UCc7L1Bx1BkEMLMA Ov0VnYNTkoTk/VQ9tPE7axLAiNN1WTWnmbn1gL8PA+5cXNVN/dDwuhFqpcTv7etg er1Gbyfk7dInd5HcRfNZOy/v7Ha92FPj0WDL7oTsDGm8YMdJIRIxkd7CW5uKfc4n e2mwyU4/EF9qUtGX1yMDv8Bj53CWng== =+k0M -----END PGP SIGNATURE----- --nextPart12828583.O9o76ZdvQC--